Skip to content

Added SSAO support on WebGPU, with R32Float fallback. #20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 8 commits into from
Oct 29, 2025
Merged

Added SSAO support on WebGPU, with R32Float fallback. #20960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7ca3bc6
Fallback to R32Float on WebGPU for ssao texture format
diyu-motif Sep 10, 2025
4e44316
added detect_r16float_support
diyu-motif Sep 10, 2025
4b09204
partially revert commit e08c78bbd to fix flickering on WebGPU
diyu-motif Sep 10, 2025
165c936
removed info and detect r16float flag
diyu-motif Sep 11, 2025
e53c622
use ShaderDefVal::UInt("SSAO_DEPTH_FORMAT" instead of #ifdef
diyu-motif Sep 12, 2025
50ad989
revert the shader fix for chrome
diyu-motif Sep 26, 2025
8fe47a0
Merge branch 'bevyengine:main' into ssao_r32
diyu-motif Sep 26, 2025
cbb1d73
Revert "use ShaderDefVal::UInt("SSAO_DEPTH_FORMAT" instead of #ifdef"
diyu-motif Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 37 additions & 22 deletions crates/bevy_pbr/src/ssao/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,6 @@ impl Plugin for ScreenSpaceAmbientOcclusionPlugin {
return;
};

if !render_app
.world()
.resource::<RenderAdapter>()
.get_texture_format_features(TextureFormat::R16Float)
.allowed_usages
.contains(TextureUsages::STORAGE_BINDING)
{
warn!("ScreenSpaceAmbientOcclusionPlugin not loaded. GPU lacks support: TextureFormat::R16Float does not support TextureUsages::STORAGE_BINDING.");
return;
}

if render_app
.world()
.resource::<RenderDevice>()
Expand Down Expand Up @@ -299,6 +288,7 @@ struct SsaoPipelines {
linear_clamp_sampler: Sampler,

shader: Handle<Shader>,
depth_format: TextureFormat,
}

impl FromWorld for SsaoPipelines {
Expand All @@ -307,6 +297,18 @@ impl FromWorld for SsaoPipelines {
let render_queue = world.resource::<RenderQueue>();
let pipeline_cache = world.resource::<PipelineCache>();

// Detect the depth format support
let render_adapter = world.resource::<RenderAdapter>();
let depth_format = if render_adapter
.get_texture_format_features(TextureFormat::R16Float)
.allowed_usages
.contains(TextureUsages::STORAGE_BINDING)
{
TextureFormat::R16Float
} else {
TextureFormat::R32Float
};

let hilbert_index_lut = render_device
.create_texture_with_data(
render_queue,
Expand Down Expand Up @@ -364,11 +366,11 @@ impl FromWorld for SsaoPipelines {
ShaderStages::COMPUTE,
(
texture_depth_2d(),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
),
),
);
Expand All @@ -381,7 +383,7 @@ impl FromWorld for SsaoPipelines {
texture_2d(TextureSampleType::Float { filterable: true }),
texture_2d(TextureSampleType::Float { filterable: false }),
texture_2d(TextureSampleType::Uint),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
texture_storage_2d(TextureFormat::R32Uint, StorageTextureAccess::WriteOnly),
uniform_buffer::<GlobalsUniform>(false),
uniform_buffer::<f32>(false),
Expand All @@ -396,11 +398,16 @@ impl FromWorld for SsaoPipelines {
(
texture_2d(TextureSampleType::Float { filterable: false }),
texture_2d(TextureSampleType::Uint),
texture_storage_2d(TextureFormat::R16Float, StorageTextureAccess::WriteOnly),
texture_storage_2d(depth_format, StorageTextureAccess::WriteOnly),
),
),
);

let mut shader_defs = Vec::new();
if depth_format == TextureFormat::R16Float {
shader_defs.push("USE_R16FLOAT".into());
}

let preprocess_depth_pipeline =
pipeline_cache.queue_compute_pipeline(ComputePipelineDescriptor {
label: Some("ssao_preprocess_depth_pipeline".into()),
Expand All @@ -409,6 +416,7 @@ impl FromWorld for SsaoPipelines {
common_bind_group_layout.clone(),
],
shader: load_embedded_asset!(world, "preprocess_depth.wgsl"),
shader_defs: shader_defs.clone(),
..default()
});

Expand All @@ -420,6 +428,7 @@ impl FromWorld for SsaoPipelines {
common_bind_group_layout.clone(),
],
shader: load_embedded_asset!(world, "spatial_denoise.wgsl"),
shader_defs,
..default()
});

Expand All @@ -437,6 +446,7 @@ impl FromWorld for SsaoPipelines {
linear_clamp_sampler,

shader: load_embedded_asset!(world, "ssao.wgsl"),
depth_format,
}
}
}
Expand Down Expand Up @@ -465,6 +475,10 @@ impl SpecializedComputePipeline for SsaoPipelines {
shader_defs.push("TEMPORAL_JITTER".into());
}

if self.depth_format == TextureFormat::R16Float {
shader_defs.push("USE_R16FLOAT".into());
}

ComputePipelineDescriptor {
label: Some("ssao_ssao_pipeline".into()),
layout: vec![
Expand Down Expand Up @@ -519,6 +533,7 @@ fn prepare_ssao_textures(
mut commands: Commands,
mut texture_cache: ResMut<TextureCache>,
render_device: Res<RenderDevice>,
pipelines: Res<SsaoPipelines>,
views: Query<(Entity, &ExtractedCamera, &ScreenSpaceAmbientOcclusion)>,
) {
for (entity, camera, ssao_settings) in &views {
Expand All @@ -535,7 +550,7 @@ fn prepare_ssao_textures(
mip_level_count: 5,
sample_count: 1,
dimension: TextureDimension::D2,
format: TextureFormat::R16Float,
format: pipelines.depth_format,
usage: TextureUsages::STORAGE_BINDING | TextureUsages::TEXTURE_BINDING,
view_formats: &[],
},
Expand All @@ -549,7 +564,7 @@ fn prepare_ssao_textures(
mip_level_count: 1,
sample_count: 1,
dimension: TextureDimension::D2,
format: TextureFormat::R16Float,
format: pipelines.depth_format,
usage: TextureUsages::STORAGE_BINDING | TextureUsages::TEXTURE_BINDING,
view_formats: &[],
},
Expand All @@ -563,7 +578,7 @@ fn prepare_ssao_textures(
mip_level_count: 1,
sample_count: 1,
dimension: TextureDimension::D2,
format: TextureFormat::R16Float,
format: pipelines.depth_format,
usage: TextureUsages::STORAGE_BINDING | TextureUsages::TEXTURE_BINDING,
view_formats: &[],
},
Expand Down Expand Up @@ -670,7 +685,7 @@ fn prepare_ssao_bind_groups(
.create_view(&TextureViewDescriptor {
label: Some("ssao_preprocessed_depth_texture_mip_view"),
base_mip_level: mip_level,
format: Some(TextureFormat::R16Float),
format: Some(pipelines.depth_format),
dimension: Some(TextureViewDimension::D2),
mip_level_count: Some(1),
..default()
Expand Down
8 changes: 8 additions & 0 deletions crates/bevy_pbr/src/ssao/preprocess_depth.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,19 @@
#import bevy_render::view::View

@group(0) @binding(0) var input_depth: texture_depth_2d;
#ifdef USE_R16FLOAT
@group(0) @binding(1) var preprocessed_depth_mip0: texture_storage_2d<r16float, write>;
@group(0) @binding(2) var preprocessed_depth_mip1: texture_storage_2d<r16float, write>;
@group(0) @binding(3) var preprocessed_depth_mip2: texture_storage_2d<r16float, write>;
@group(0) @binding(4) var preprocessed_depth_mip3: texture_storage_2d<r16float, write>;
@group(0) @binding(5) var preprocessed_depth_mip4: texture_storage_2d<r16float, write>;
#else
@group(0) @binding(1) var preprocessed_depth_mip0: texture_storage_2d<r32float, write>;
@group(0) @binding(2) var preprocessed_depth_mip1: texture_storage_2d<r32float, write>;
@group(0) @binding(3) var preprocessed_depth_mip2: texture_storage_2d<r32float, write>;
@group(0) @binding(4) var preprocessed_depth_mip3: texture_storage_2d<r32float, write>;
@group(0) @binding(5) var preprocessed_depth_mip4: texture_storage_2d<r32float, write>;
#endif
@group(1) @binding(0) var point_clamp_sampler: sampler;
@group(1) @binding(1) var linear_clamp_sampler: sampler;
@group(1) @binding(2) var<uniform> view: View;
Expand Down
4 changes: 4 additions & 0 deletions crates/bevy_pbr/src/ssao/spatial_denoise.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@

@group(0) @binding(0) var ambient_occlusion_noisy: texture_2d<f32>;
@group(0) @binding(1) var depth_differences: texture_2d<u32>;
#ifdef USE_R16FLOAT
@group(0) @binding(2) var ambient_occlusion: texture_storage_2d<r16float, write>;
#else
@group(0) @binding(2) var ambient_occlusion: texture_storage_2d<r32float, write>;
#endif
@group(1) @binding(0) var point_clamp_sampler: sampler;
@group(1) @binding(1) var linear_clamp_sampler: sampler;
@group(1) @binding(2) var<uniform> view: View;
Expand Down
4 changes: 4 additions & 0 deletions crates/bevy_pbr/src/ssao/ssao.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
@group(0) @binding(0) var preprocessed_depth: texture_2d<f32>;
@group(0) @binding(1) var normals: texture_2d<f32>;
@group(0) @binding(2) var hilbert_index_lut: texture_2d<u32>;
#ifdef USE_R16FLOAT
@group(0) @binding(3) var ambient_occlusion: texture_storage_2d<r16float, write>;
#else
@group(0) @binding(3) var ambient_occlusion: texture_storage_2d<r32float, write>;
#endif
@group(0) @binding(4) var depth_differences: texture_storage_2d<r32uint, write>;
@group(0) @binding(5) var<uniform> globals: Globals;
@group(0) @binding(6) var<uniform> thickness: f32;
Expand Down