Skip to content

UiSystems::Clipping system set - #25910

Merged
alice-i-cecile merged 3 commits into
bevyengine:mainfrom
ickshonpe:uisystems-clipping
Sep 24, 2026
Merged

alice-i-cecile merged 3 commits into
bevyengine:mainfrom
ickshonpe:uisystems-clipping

Conversation

@ickshonpe

Copy link
Copy Markdown
Contributor

Objective

update_clipping_system runs in UiSystems::PostLayout. This doesn't make sense to me, as the layout isn't finished until the clipping geometry is generated. But it shouldn't be in UiSystems::Layout probably either, there is some post layout adjustment in bevy_widgets that needs to be done after the ComputedNodes updates but before clipping.

Solution

New UiSystems::Clipping system set. Move update_clipping_system into UiSystems::Clipping.

…g_system` is scheduled to run in this set now instead of `PostLayout`.
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Sep 24, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Sep 24, 2026
@ickshonpe ickshonpe added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Sep 24, 2026
@mnmaita mnmaita added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Sep 24, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 24, 2026
@alice-i-cecile
alice-i-cecile added this pull request to the merge queue Sep 24, 2026
Merged via the queue into bevyengine:main with commit 40a8729 Sep 24, 2026
43 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Sep 24, 2026
shengyusi-SYS added a commit to shengyusi-SYS/bevy that referenced this pull request Nov 12, 2026
Bring in the UI layout benchmark workloads from upstream bevyengine#25973 and bevyengine#25989, and the clipping schedule prerequisite from bevyengine#25910, before backporting incremental UI layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants