Repository navigation
UiSystems::Clipping system set - #25910
Merged
Merged
Conversation
…g_system` is scheduled to run in this set now instead of `PostLayout`.
…g` instead of `update_clipping_system`.
mnmaita
approved these changes
Sep 24, 2026
alice-i-cecile
approved these changes
Sep 24, 2026
shengyusi-SYS
added a commit
to shengyusi-SYS/bevy
that referenced
this pull request
Nov 12, 2026
Bring in the UI layout benchmark workloads from upstream bevyengine#25973 and bevyengine#25989, and the clipping schedule prerequisite from bevyengine#25910, before backporting incremental UI layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
update_clipping_systemruns inUiSystems::PostLayout. This doesn't make sense to me, as the layout isn't finished until the clipping geometry is generated. But it shouldn't be inUiSystems::Layoutprobably either, there is some post layout adjustment inbevy_widgetsthat needs to be done after theComputedNodesupdates but before clipping.Solution
New
UiSystems::Clippingsystem set. Moveupdate_clipping_systemintoUiSystems::Clipping.