Repository navigation
Fix timer remaining-time panic and completion-count overflow - #25995
Merged
alice-i-cecile merged 2 commits intoOct 6, 2026
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Oct 4, 2026
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Yep, trivially correct. Annoying. We should consider enabling stricter lints for this stuff, at least locally within this crate.
kfc35
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two timer edge cases:
remaining(): return zero instead of panicking when elapsed exceeds duration.tick(): saturate the completion count instead of wrapping, preservingjust_finished().Regression tests included. 87 tests/doc-tests passed; Clippy, formatting and the
no_stdcheck passed.AI disclosure: Codex assisted with analysis, code, tests and PR wording. I reviewed the changes and ran the tests.