Repository navigation
[Merged by Bors] - Support tuple structs with #[derive(SystemParam)] - #6957
Closed
joseph-gio wants to merge 1 commit into
Closed
joseph-gio wants to merge 1 commit into
joseph-gio wants to merge 1 commit into
Conversation
Member
Author
|
Note that this does not conflict with #6919. |
joseph-gio
added
C-Feature
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
This is correct and a natural extension. I don't think I'd ever use it myself though, and I'd complain against it being used in any project I was doing code review for.
Tuple structs are just generally kind of a mess to work with, and using them for reusable types like this feels wrong.
That said, if people want this I wouldn't want to block this PR.
Member
Author
|
I agree that tuple struct system params are not especially desirable -- named fields tend to be better (although this is true for tuple structs in general, it's not specific to SystemParams). Really, I see this PR as rounding out the engine by removing arbitrary limitations and places where users may experience friction. Given how prevalent anonymous tuples are in bevy, I believe most users will rightfully assume that tuple structs would just work with the derive macro. The moment when they try it and have to rewrite their type is an unfortunate toe-stub that I'd like to eliminate. |
alice-i-cecile
approved these changes
Dec 15, 2022
james7132
approved these changes
Dec 20, 2022
james7132
left a comment
james7132
left a comment
Member
There was a problem hiding this comment.
Gonna agree that this shouldn't be promoted, but it removes one sharp edge from the API.
james7132
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# Objective Currently, only named structs can be used with the `SystemParam` derive macro. ## Solution Remove the restriction. Tuple structs and unit structs are now supported. --- ## Changelog + Added support for tuple structs and unit structs to the `SystemParam` derive macro.
bors
Bot
changed the title
#[derive(SystemParam)]#[derive(SystemParam)]
joseph-gio
added a commit
to joseph-gio/bevy
that referenced
this pull request
Dec 21, 2022
Currently, only named structs can be used with the `SystemParam` derive macro. Remove the restriction. Tuple structs and unit structs are now supported. --- + Added support for tuple structs and unit structs to the `SystemParam` derive macro.
bors Bot
pushed a commit
that referenced
this pull request
Dec 25, 2022
# Objective * Currently, the `SystemParam` derive does not support types with const generic parameters. * If you try to use const generics, the error message is cryptic and unhelpful. * Continuation of the work started in #6867 and #6957. ## Solution Allow const generic parameters to be used with `#[derive(SystemParam)]`.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective Currently, only named structs can be used with the `SystemParam` derive macro. ## Solution Remove the restriction. Tuple structs and unit structs are now supported. --- ## Changelog + Added support for tuple structs and unit structs to the `SystemParam` derive macro.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective * Currently, the `SystemParam` derive does not support types with const generic parameters. * If you try to use const generics, the error message is cryptic and unhelpful. * Continuation of the work started in bevyengine#6867 and bevyengine#6957. ## Solution Allow const generic parameters to be used with `#[derive(SystemParam)]`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Currently, only named structs can be used with the `SystemParam` derive macro. ## Solution Remove the restriction. Tuple structs and unit structs are now supported. --- ## Changelog + Added support for tuple structs and unit structs to the `SystemParam` derive macro.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective * Currently, the `SystemParam` derive does not support types with const generic parameters. * If you try to use const generics, the error message is cryptic and unhelpful. * Continuation of the work started in bevyengine#6867 and bevyengine#6957. ## Solution Allow const generic parameters to be used with `#[derive(SystemParam)]`.
cart
pushed a commit
that referenced
this pull request
Apr 4, 2023
# Objective The `#[derive(WorldQuery)]` macro currently only supports structs with named fields. Same motivation as #6957. Remove sharp edges from the derive macro, make it just work more often. ## Solution Support tuple structs. --- ## Changelog + Added support for tuple structs to the `#[derive(WorldQuery)]` macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently, only named structs can be used with the
SystemParamderive macro.Solution
Remove the restriction. Tuple structs and unit structs are now supported.
Changelog
SystemParamderive macro.