Skip to content

Add all basic color constants - #859

Merged
cart merged 3 commits into
masterfrom
unknown repository
Nov 15, 2020
Merged

cart merged 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 13, 2020

Copy link
Copy Markdown

No description provided.

@karroffel karroffel added core C-Feature A new feature, making something new possible labels Nov 13, 2020
Comment thread crates/bevy_render/src/color.rs Outdated

impl Color {
pub const ALICEBLUE: Color = Color::rgb_linear(0.94, 0.97, 1.0);
pub const ANTIQUEWHITE: Color = Color::rgb_linear(0.98, 0.92, 0.84);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we "rustify" these multi-word constants? Ex: ANTIQUEWHITE -> ANTIQUE_WHITE

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@cart
cart merged commit b3541a9 into bevyengine:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Feature A new feature, making something new possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants