Use new Serialport isOpen boolean API - #2
Merged
Merged
Conversation
I was getting errors about isOpen being a boolean, because apparently serialport has changed the API here
Contributor
Author
|
cc @cinderblock |
TimPietrusky
self-requested a review
December 3, 2018 20:57
Member
|
We should also update the documentation to reflect which version of node-serialport is working with the driver. @ericvicenti Do you know when this change in the API was introduced? |
|
Looks like this change happend in SerialPort 5.x https://github.com/node-serialport/node-serialport/blob/160cf33bdbf331775ae2ccce8f374ec9e0988048/packages/serialport/UPGRADE_GUIDE.md#upgrading-from-4x-to-5x Maybe this should be updated to test if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting errors about isOpen being a boolean, because apparently serialport has changed the API here