gui: disable font antialiasing for QR image address - #17257
Merged
Merged
Conversation
More info available here: https://doc.qt.io/qt-5/qfont.html#StyleStrategy-enum
Contributor
|
That sounds like a platform bug? Would rather not disable antialias (an improvement) because of some platforms doing it wrong... |
Member
Author
I didn't mention a specific platform in the PR description, because disabling has been an improvement on all the platforms I tested. Can you show me where it's a regression in readability? |
Member
|
ACK e156b9d Readability takes precedence here over a debatable "improvement" in rendering. On the longer term someone could figure out the cause, and come up with a better patch, but at least this trivial change we can still sneak into 0.19.0.
FWIW this looks is a bitmap font, which really don't lend themselves to anti-aliasing, only vector fonts do. |
Contributor
|
ACK |
Contributor
|
Gitian builds for commit 25d7e2e (master):
Gitian builds for commit 7499c796fb447a9de846252a7fa336c684ace90b (master and this pull):
|
laanwj
added a commit
that referenced
this pull request
Oct 26, 2019
e156b9d gui: disable font antialiasing for QR image address (fanquake) Pull request description: The address text inside the QR code is currently fairly blurry / unreadable. Explicitly disabling font antialiasing improves that somewhat. master (693e400):  PR (e156b9d):  ACKs for top commit: laanwj: ACK e156b9d Tree-SHA512: 32aeb2ffe8164a1006f80e76c6e413fcb88e32ced42d2b2af69cca908bd32673f3e379184be917f1870864b940db943e7f46a7ecb0779343d5d129b381660c38
laanwj
pushed a commit
that referenced
this pull request
Oct 26, 2019
More info available here: https://doc.qt.io/qt-5/qfont.html#StyleStrategy-enum Github-Pull: #17257 Rebased-From: e156b9d Tree-SHA512: 6e36d626215d5e66796bd3935037eef89ae810e4855e321f9f37b90c3be0b61de21cd655f23bc6a29f41038b5179d92578ab19ab89ccd525d9389ab868456827
Contributor
|
ACK eb5a899. |
SmarterHomes
pushed a commit
to SmarterHomes/chaincoin
that referenced
this pull request
Nov 17, 2019
More info available here: https://doc.qt.io/qt-5/qfont.html#StyleStrategy-enum Github-Pull: bitcoin#17257 Rebased-From: e156b9d Tree-SHA512: 6e36d626215d5e66796bd3935037eef89ae810e4855e321f9f37b90c3be0b61de21cd655f23bc6a29f41038b5179d92578ab19ab89ccd525d9389ab868456827
Member
|
Reverting suggested in bitcoin-core/gui#71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The address text inside the QR code is currently fairly blurry / unreadable. Explicitly disabling font antialiasing improves that somewhat.
master (693e400):
PR (e156b9d):
