Skip to content

tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals - #17996

Merged
maflcko merged 4 commits into
bitcoin:masterfrom
practicalswift:fuzzers-float
Mar 5, 2020
Merged

maflcko merged 4 commits into
bitcoin:masterfrom
practicalswift:fuzzers-float

Conversation

@practicalswift

@practicalswift practicalswift commented Jan 24, 2020 •

Copy link
Copy Markdown
Contributor

Add simple fuzzing harness for functions with floating-point parameters (such as ser_double_to_uint64(double), etc.).

Add serialization/deserialization fuzzing for integral types.

Add missing includes.

To test this PR:

$ make distclean
$ ./autogen.sh
$ CC=clang CXX=clang++ ./configure --enable-fuzz \
      --with-sanitizers=address,fuzzer,undefined
$ make
$ src/test/fuzz/float
…

@practicalswift practicalswift changed the title tests: Add fuzzing harness for functions with floating-point parameters tests: Add fuzzing harness for functions with floating-point parameters. Update FuzzedDataProvider.h. Jan 24, 2020
@practicalswift practicalswift changed the title tests: Add fuzzing harness for functions with floating-point parameters. Update FuzzedDataProvider.h. tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals. Update FuzzedDataProvider.h. Jan 24, 2020
@practicalswift practicalswift changed the title tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals. Update FuzzedDataProvider.h. tests: Add fuzzing harness for serialization/deserialization of floating-points and integrals Jan 31, 2020
@DrahtBot

DrahtBot commented Feb 11, 2020 •

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Comment thread src/test/fuzz/integer.cpp Outdated
@maflcko
maflcko merged commit a2b5aae into bitcoin:master Mar 5, 2020
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request May 7, 2020
Summary:
As per title, needed for coming changes.

They are fixed by core in commit
bitcoin/bitcoin@c2bd588
from the very unrelated [[bitcoin/bitcoin#17996 | PR17996]], but since this PR has an infinite depth
of dependencies I just cherry pick this commit for now.

Test Plan:
  ninja all check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5990
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this pull request Aug 17, 2020
Summary:
As per title, needed for coming changes.

They are fixed by core in commit
bitcoin/bitcoin@c2bd588
from the very unrelated [[bitcoin/bitcoin#17996 | PR17996]], but since this PR has an infinite depth
of dependencies I just cherry pick this commit for now.

Test Plan:
  ninja all check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5990
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 3, 2020
…ing-points and integrals

Summary:
```
Add simple fuzzing harness for functions with floating-point parameters
(such as ser_double_to_uint64(double), etc.).

Add serialization/deserialization fuzzing for integral types.
```

Backport of core [[bitcoin/bitcoin#17996 | PR17996]].

The first and last commit are not relevant to us.

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py <path_to_corpus>

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8249
@practicalswift
practicalswift deleted the fuzzers-float branch April 10, 2021 19:39
kwvg added a commit to kwvg/dash that referenced this pull request Mar 24, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants