Skip to content

Delete duplicate response_to_json, unify on response_to_event_dict - #3473

Merged
liquidsec merged 2 commits into
devfrom
unify-response-to-event-dict
Oct 5, 2026
Merged

liquidsec merged 2 commits into
devfrom
unify-response-to-event-dict

Conversation

@liquidsec

Copy link
Copy Markdown
Contributor

Summary

  • Deletes WebHelper.response_to_json() and switches wayback to the canonical response_to_event_dict() that http and lightfuzz already use
  • Wayback's HTTP_RESPONSE events now get title, location, content_length, a proper raw_header with a status line, correct duplicate-header joining, and Rust-computed hashes instead of redundant Python recomputation
  • Strips cert_info from archived responses since it belongs to archive.org, not the original target

Code hygiene: two near-duplicate functions building the same event dict diverged over time, producing subtly different output depending on which module found the response. Closes #3386.

@liquidsec liquidsec linked an issue Sep 28, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91%. Comparing base (58fe07e) to head (cb82c72).
⚠️ Report is 8 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3473   +/-   ##
=====================================
+ Coverage     91%     91%   +1%     
=====================================
  Files        460     460           
  Lines      48998   48973   -25     
=====================================
- Hits       44115   44094   -21     
+ Misses      4883    4879    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs unify-response-to-event-dict (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 3.94ms 3.79ms -3.8% ⚪ ✅
Bloom Filter Large Scale Dns Brute Force 15.23ms 15.40ms +1.1% ⚪ ✅
Large Closest Match Lookup 329.98ms 341.41ms +3.5% ⚪ ✅
Realistic Closest Match Workload 180.04ms 181.44ms +0.8% ⚪ ✅
Event Memory Medium Scan 1402 B/event 1404 B/event +0.2% ⚪ ✅
Event Memory Large Scan 1527 B/event 1527 B/event +0.0% ⚪ ✅
Event Validation Full Scan Startup Small Batch 409.47ms 413.62ms +1.0% ⚪ ✅
Event Validation Full Scan Startup Large Batch 522.70ms 523.60ms +0.2% ⚪ ✅
Make Event Autodetection Small 20.71ms 20.93ms +1.1% ⚪ ✅
Make Event Autodetection Large 208.17ms 210.42ms +1.1% ⚪ ✅
Make Event Explicit Types 8.54ms 8.66ms +1.3% ⚪ ✅
Excavate Single Thread Small 3.905s 3.739s -4.3% ⚪ ✅
Excavate Single Thread Large 9.474s 9.400s -0.8% ⚪ ✅
Excavate Parallel Tasks Small 4.048s 3.877s -4.2% ⚪ ✅
Excavate Parallel Tasks Large 6.095s 5.935s -2.6% ⚪ ✅
Intercept Throughput Small 872.76ms 893.15ms +2.3% ⚪ ✅
Intercept Throughput Medium 939.30ms 880.01ms -6.3% ⚪ ✅
Dns Throughput Quiet 2.498s 2.586s +3.5% ⚪ ✅
Dns Throughput Loaded 1.889s 1.739s -8.0% ⚪ ✅
Dns Throughput Inherited 2.186s 2.285s +4.5% ⚪ ✅
Is Ip Performance 2.28ms 2.31ms +1.4% ⚪ ✅
Make Ip Type Performance 206.01µs 205.15µs -0.4% ⚪ ✅
Mixed Ip Operations 2.38ms 2.38ms +0.2% ⚪ ✅
Memory Use Web Crawl 1.2 MB 1.2 MB +0.0% ⚪ ✅
Memory Use Subdomain Enum 28.3 MB 28.3 MB +0.0% ⚪ ✅
Memory Use Deep Chain 5.0 MB 5.0 MB +0.0% ⚪ ✅
Memory Use Parallel Chains 12.9 MB 10.8 MB -16.6% 🟢🟢 🚀
Scan Throughput 100 2.682s 2.530s -5.6% ⚪ ✅
Scan Throughput 1000 17.546s 17.812s +1.5% ⚪ ✅
Typical Queue Shuffle 5.55µs 5.47µs -1.3% ⚪ ✅
Priority Queue Shuffle 27.47µs 27.25µs -0.8% ⚪ ✅

🎯 Performance Summary

+ 1 improvement 🚀
  30 unchanged ✅

🔍 Significant Changes (>10%)

  • Memory Use Parallel Chains: 16.6% 🚀 less memory

🐍 Python Version 3.11.16

@liquidsec
liquidsec merged commit 652839f into dev Oct 5, 2026
20 checks passed
@liquidsec
liquidsec deleted the unify-response-to-event-dict branch October 5, 2026 18:13
This was referenced Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP_RESPONSE event data is built by two divergent functions

2 participants