Repository navigation
Delete duplicate response_to_json, unify on response_to_event_dict - #3473
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3473 +/- ##
=====================================
+ Coverage 91% 91% +1%
=====================================
Files 460 460
Lines 48998 48973 -25
=====================================
- Hits 44115 44094 -21
+ Misses 4883 4879 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary+ 1 improvement 🚀
30 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.16 |
liquidsec
added a commit
that referenced
this pull request
Sep 28, 2026
en0f
approved these changes
Oct 5, 2026
This was referenced Oct 26, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebHelper.response_to_json()and switches wayback to the canonicalresponse_to_event_dict()that http and lightfuzz already usetitle,location,content_length, a properraw_headerwith a status line, correct duplicate-header joining, and Rust-computed hashes instead of redundant Python recomputationcert_infofrom archived responses since it belongs to archive.org, not the original targetCode hygiene: two near-duplicate functions building the same event dict diverged over time, producing subtly different output depending on which module found the response. Closes #3386.