Skip to content

Don't tag in-scope events as affiliate - #3524

Merged
liquidsec merged 1 commit into
devfrom
affiliate-in-scope
Oct 14, 2026
Merged

liquidsec merged 1 commit into
devfrom
affiliate-in-scope

Conversation

@liquidsec

Copy link
Copy Markdown
Contributor

refresh_scope_tags() removes affiliate when an event becomes in-scope. But Event.__init__ sets the parent (and scope distance) before adding tags, so an affiliate tag passed at creation, or inherited from the parent, arrived after that check and was never removed. Excavate tags every Location-header redirect affiliate, so in-scope redirects kept it and passed it to all same-host descendants.

add_tag now ignores affiliate on in-scope events.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91%. Comparing base (ce6decf) to head (b93b4a3).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3524   +/-   ##
=====================================
- Coverage     91%     91%   -0%     
=====================================
  Files        461     461           
  Lines      49625   49640   +15     
=====================================
+ Hits       44769   44776    +7     
- Misses      4856    4864    +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs affiliate-in-scope (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 3.72ms 3.77ms +1.3% ⚪ ✅
Bloom Filter Large Scale Dns Brute Force 15.31ms 15.34ms +0.2% ⚪ ✅
Large Closest Match Lookup 326.35ms 345.65ms +5.9% ⚪ ✅
Realistic Closest Match Workload 181.51ms 180.76ms -0.4% ⚪ ✅
Event Memory Medium Scan 1402 B/event 1402 B/event +0.0% ⚪ ✅
Event Memory Large Scan 1527 B/event 1527 B/event +0.0% ⚪ ✅
Event Validation Full Scan Startup Small Batch 404.80ms 404.42ms -0.1% ⚪ ✅
Event Validation Full Scan Startup Large Batch 516.00ms 516.15ms +0.0% ⚪ ✅
Make Event Autodetection Small 20.94ms 20.91ms -0.1% ⚪ ✅
Make Event Autodetection Large 209.16ms 207.06ms -1.0% ⚪ ✅
Make Event Explicit Types 8.51ms 8.48ms -0.4% ⚪ ✅
Excavate Single Thread Small 3.774s 3.794s +0.5% ⚪ ✅
Excavate Single Thread Large 9.321s 9.281s -0.4% ⚪ ✅
Excavate Parallel Tasks Small 4.003s 4.027s +0.6% ⚪ ✅
Excavate Parallel Tasks Large 6.058s 5.995s -1.0% ⚪ ✅
Intercept Throughput Small 897.69ms 882.30ms -1.7% ⚪ ✅
Intercept Throughput Medium 885.01ms 971.60ms +9.8% ⚪ ✅
Dns Throughput Quiet 2.546s 2.506s -1.6% ⚪ ✅
Dns Throughput Loaded 1.763s 1.855s +5.2% ⚪ ✅
Dns Throughput Inherited 2.121s 2.146s +1.2% ⚪ ✅
Is Ip Performance 2.26ms 2.27ms +0.1% ⚪ ✅
Make Ip Type Performance 197.01µs 205.44µs +4.3% ⚪ ✅
Mixed Ip Operations 2.32ms 2.37ms +1.9% ⚪ ✅
Memory Use Web Crawl 1.2 MB 1.2 MB +0.0% ⚪ ✅
Memory Use Subdomain Enum 28.3 MB 28.3 MB +0.0% ⚪ ✅
Memory Use Deep Chain 5.0 MB 5.0 MB +0.0% ⚪ ✅
Memory Use Parallel Chains 12.4 MB 13.4 MB +7.6% ⚪ ✅
Scan Throughput 100 2.756s 2.602s -5.6% ⚪ ✅
Scan Throughput 1000 17.953s 18.330s +2.1% ⚪ ✅
Typical Queue Shuffle 5.36µs 5.45µs +1.6% ⚪ ✅
Priority Queue Shuffle 26.87µs 26.91µs +0.1% ⚪ ✅

🎯 Performance Summary

✅ No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.17

@liquidsec
liquidsec merged commit 603978e into dev Oct 14, 2026
19 checks passed
@liquidsec
liquidsec deleted the affiliate-in-scope branch October 14, 2026 14:25
This was referenced Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants