Repository navigation
Resolve ./ form actions relative to the page - #3525
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## excavate-base-href #3525 +/- ##
==================================================
- Coverage 91% 91% -0%
==================================================
Files 461 461
Lines 49652 49665 +13
==================================================
+ Hits 44791 44800 +9
- Misses 4861 4865 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary+ 1 improvement 🚀
! 2 regressions ⚠️
28 unchanged ✅🔍 Significant Changes (>10%)
🐍 Python Version 3.11.17 |
en0f
approved these changes
Oct 13, 2026
liquidsec
added a commit
that referenced
this pull request
Oct 14, 2026
* Resolve excavated relative URLs against <base href> * Resolve ./ form actions relative to the page (#3525) * Fix excavate parameter extraction on RAW_TEXT events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetForm stripped the leading dot from
./form actions, which made them root-relative:./xon/app/sub/pagebecame/xinstead of/app/sub/x. The strip was needed when form URLs were built by string concatenation. They now go throughurljoin, which handles./correctly, so the strip only breaks pages below the root.Targets #3522 because its
<base href>test case depends on that fix.