feat(desktop): autocomplete ACP slash commands - #2653
Conversation
Signed-off-by: kevb10 <gasydev@gmail.com>
d8321ea to
3f63a36
Compare
|
We'd like to see this land, so we did a full review of this PR against today's Review findingsStrengths:
Gaps worth follow-ups (not blockers in our view):
What the rebased branch addsAll feature credit to @kevinmanase; we started from the conflict resolutions in #3537 (thanks to its author too) and brought it the rest of the way:
Related work, for cross-reference: this implements #2528 and also covers the ask in #5741; #6567 builds the picker-chip UI for the same space but without persistence or the typed- Happy to open the rebased branch as a fresh PR, or hand it off however is easiest — whichever the maintainers prefer. |
Summary
available_commands_updatenotifications as encrypted semantic observer snapshotsBehavior
Typing
/at the start of a message shows commands advertised by agent members in the channel. Typing/after one or more leading@Agentmentions narrows suggestions to those agents. Duplicate command names stay grouped by provider, empty updates remove stale commands, and catalogs survive app restarts.Testing
pnpm --dir desktop test(3,466 passing)pnpm --dir desktop checkpnpm --dir desktop typecheckpnpm --dir desktop buildcargo test -p buzz-acp available_commands_update_emits_complete_semantic_snapshotcargo clippy -p buzz-acp --all-targets -- -D warningscargo fmt --all -- --checkFixes #2528