test(desktop): stabilize keyboard community reorder - #4652
Open
kiranmagic7 wants to merge 3 commits into
Open
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
Contributor
Author
|
Re-checked the current head Review focus is the one-file Playwright synchronization in |
…keyboard-reorder-flake Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wait one browser timer tick after the keyboard drag is picked up and before sending
ArrowUp.@dnd-kit'sKeyboardSensorcallshandleStart()synchronously, then installs its documentkeydownlistener insidesetTimeout. Pick-up state is already visible during that gap, so waiting foraria-pressedcannot prove that the listener is ready. Crossing the macrotask boundary directly closes the race. Product behavior is unchanged.Related issue
Fixes #4530. The source-derived mechanism and independent evidence are documented in #6007; that issue also tracks three separate flakes outside this PR.
Testing
On current
upstream/main(d8281b9c9), the isolated test failed 18/30 runs with retries disabled.With this patch, the isolated test passed 60/60 runs with retries disabled:
just ciScreenshots are not applicable; this is a test-only change.