fix(buzz-acp): loosen workspace-scan guardrail to allow named paths - #6261
Open
salman1993 wants to merge 1 commit into
Open
fix(buzz-acp): loosen workspace-scan guardrail to allow named paths#6261salman1993 wants to merge 1 commit into
salman1993 wants to merge 1 commit into
Conversation
The [Workspace] anchor and base-prompt layout note told agents not to search $HOME 'or other directories', which cautious models overgeneralized into a filesystem wall — refusing to read a specific, user-named path outside .buzz. That over-application is what Aaron and Wes hit. Reframe both fragments per context-engineering guidance: give the reason (start at the grounded workspace; a $HOME scan is not what the user intended unless they ask for it) and explicitly permit reading any specific path the user names, inside or outside $HOME. Keeps the original anchor intent (avoid unscoped $HOME sweeps that fire macOS TCC prompts / invent workspace dirs) without the blanket prohibition. Co-authored-by: Salman Mohammed <smohammed@squareup.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>
Contributor
Author
|
🤖 Benchmark result using Test setup:
Results:
One separate tool ergonomics issue remains: all five runs first passed literal |
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agents refused to read a specific, user-named path outside
.buzz(e.g.~/.claude/skills/context-health-check/SKILL.md), and behaved inconsistently — refusing in one channel, listing the same dir in another. This is the issue Aaron and Wes hit: buzz://message?channel=e62570dd-33ad-42c5-b92b-75f2689f9694&id=401199157f8a9734109fdddfbbce4603a1ff465fae895042f29738ad52a5d15fRoot cause: two prompt fragments told agents not to search
$HOME"or other directories". The intent (added in #1194 by Will Pfleger) was narrow — stop unscoped$HOMEsweeps that fire macOS TCC dialogs or make a model invent its own workspace dir. But "or other directories" reads as a blanket filesystem wall, so a cautious model generalized it to "any path outside.buzz" and refused a targeted, named read.Fix
Prompt-only. Reframe both fragments per context-engineering guidance — state the reason and trust judgement, rather than banning a technique:
crates/buzz-acp/src/pool.rs—workspace_section()crates/buzz-acp/src/base_prompt.mdline 106Preserves the original anchor intent (start at the grounded workspace; avoid unscoped
$HOMEsweeps) while explicitly permitting a named-path read — the exact case that was broken.Testing
cargo test -p buzz-acp— 816 unit + 9 integration tests pass, 0 failures. Prompt-only change; the doc comment atpool.rs:1327-1333already states the narrow intent and is left as-is.