Repository navigation
core: services: kraken: properly cleanup when uninstalling an extension - #1197
Merged
Merged
Conversation
Williangalvani
marked this pull request as draft
October 21, 2022 14:20
Williangalvani
force-pushed
the
uninstall
branch
from
October 21, 2022 14:25
4c6e60f to
bbbc0cf
Compare
Williangalvani
marked this pull request as ready for review
October 21, 2022 14:26
15 of 19 tasks
patrickelectric
requested changes
Oct 21, 2022
| async def remove(self, container_name: str) -> None: | ||
| logger.info(f"Removing container {container_name}") | ||
| container = await self.client.containers.list(filters={"name": {container_name: True}}) # type: ignore | ||
| if container: |
Member
There was a problem hiding this comment.
We should deal with the error before the main logic of the code, warning about it and avoiding the extra indentation level
if not container:
raise ContainerDoesNotExist
Williangalvani
force-pushed
the
uninstall
branch
from
October 21, 2022 15:41
bbbc0cf to
6464023
Compare
Williangalvani
force-pushed
the
uninstall
branch
from
October 21, 2022 16:42
6464023 to
41ae620
Compare
patrickelectric
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.