Repository navigation
kraken: Add treatment for ext start when offline - #2736
Merged
Williangalvani merged 1 commit intoJun 24, 2024
Merged
Conversation
joaomariolago
force-pushed
the
fix-kraken-offline-starter
branch
3 times, most recently
from
June 24, 2024 14:50
ea4cdd3 to
b9e3167
Compare
* Add ManifestBackendOffline error in manifest fetch * Add treatment to try to start anyway if fails to fetch manifest
joaomariolago
force-pushed
the
fix-kraken-offline-starter
branch
from
June 24, 2024 15:09
b9e3167 to
a26e786
Compare
joaomariolago
marked this pull request as ready for review
June 24, 2024 15:23
joaomariolago
requested review from
Williangalvani,
joaoantoniocardoso and
patrickelectric
June 24, 2024 15:23
Williangalvani
approved these changes
Jun 24, 2024
Williangalvani
left a comment
Williangalvani
left a comment
Member
There was a problem hiding this comment.
lgtm!
tested with no internet and working as expected
15 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2727