Repository navigation
Core: Kraken: Improve main loop tasks and add exp delay to avoid flooding - #2922
Merged
patrickelectric merged 2 commits intoSep 26, 2024
Merged
Conversation
joaomariolago
force-pushed
the
improve-main-kraken-loop
branch
from
September 26, 2024 12:19
e063693 to
8c87824
Compare
joaomariolago
marked this pull request as ready for review
September 26, 2024 15:12
joaomariolago
requested review from
Williangalvani,
joaoantoniocardoso and
patrickelectric
September 26, 2024 15:12
joaomariolago
force-pushed
the
improve-main-kraken-loop
branch
2 times, most recently
from
September 26, 2024 15:14
3c6af82 to
45d6009
Compare
patrickelectric
requested changes
Sep 26, 2024
* Add tracking of times of attempt to start a given extension and last time it was started for better main loop control * Change formated string with ext unique entry used in multiple places to a ext property
joaomariolago
force-pushed
the
improve-main-kraken-loop
branch
from
September 26, 2024 16:43
45d6009 to
32b791e
Compare
* Separate start extension task from garbage collection ones * Add exp delay in starting attempts to avoid dead extensions from flooding kraken loop trying to restart itself
joaomariolago
force-pushed
the
improve-main-kraken-loop
branch
from
September 26, 2024 16:51
cd07970 to
fb578a5
Compare
patrickelectric
approved these changes
Sep 26, 2024
15 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some extensions may be failing to start repeatedly, add a exp delay and start attempts tracking to avoid kraken main loop being flooded with start attempts and degrade overall performance