Npm registry version differs from github release聽#690
Description
Overview of the problem
I'm using react-rnd version [10.1.9] (see npm)
My browser is: Chrome (electron)
Steps to Reproduce
yarn add react-rnd- Version in
package.jsonwill be10.1.9
Expected behavior
Version to be consistent with github releases (10.1.8 or 9.1.1)
Activity
NeroVanbiervliet commentedon May 8, 2020
As a side node, version
10.1.9made our application crash upon building.bokuweb commentedon May 8, 2020
@NeroVanbiervliet Thanks for your report :) Could you please provide reproduced project in codesandbox? It seems that 10.1.9 works following sample.
https://codesandbox.io/s/y3997qply9
NeroVanbiervliet commentedon May 8, 2020
I cannot reproduce it in codesandbox. In our project, it works fine in development using
webpack-dev-server. But as soon as I bundle our code for production, it crashes. We get the following errorSwitching to
10.1.8solved the issue.I can provide you with more info concerning our environment/project setup if you wish!
bokuweb commentedon May 8, 2020
@NeroVanbiervliet I guess react-draggable cause this error. react-grid-layout/react-draggable#476
I'll downgrade react-draggable for now.
10.1.10 #690
10.1.10 #690 (#691)
bokuweb commentedon May 8, 2020
Downgrade react-draggable for now
bokuweb commentedon May 8, 2020
https://github.com/bokuweb/react-rnd/releases/tag/v10.1.10
NeroVanbiervliet commentedon May 8, 2020
Confirmed fixed :) Thanks a lot!
STRML commentedon May 11, 2020
Hi - if any of you can recreate this error in React-Draggable 4.3.1 we'd be very happy to find out how you did it. There is no appreciable difference we can find in the bundling between 4.2.0 and 4.3.1, but many users are reporting this with no reproduction.
If someone could post a reproduction, we can get it fixed quickly.
bokuweb commentedon May 11, 2020
@NeroVanbiervliet @MBaert Do you have any information about this?
NeroVanbiervliet commentedon May 12, 2020
I created a fork of an electron boilerplate to demonstrate the issue here. In my only commit I added
react-rnd @ 10.1.9and imported it in the index.Reproduction steps
yarn installyarn packagebuilds/As stated above the error only occurs after bundling, not in dev mode.
STRML commentedon May 12, 2020
Thank you very much @NeroVanbiervliet. Because of your reproduction I was able to verify that
react-draggable@4.4.0fixes the original issue, and discovered another bundling issue that is fixed in4.4.1.@bokuweb thanks for your patience with me, I had a hare-brained idea to modernize the builds I was shipping to support umd, cjs, and modules - an exercise in futility to handle well, with the costs far outweighing the benefits. Most of that work is deleted in
4.4.1, and the only exposed build is ES5-compliant, unminified, CJS source.