fix(telemetry): make telemetry opt-in and off by default - #2
Conversation
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (24)
Comment |
Upstream treats the default
"unset"telemetry state as opted in (opt-out semantics), so any build made with aPOSTHOG_API_KEYbaked in sends usage data keyed tovscode.env.machineIdbefore the user answers the consent banner. This flips the gate to true opt-in in both hosts:Dismissing the first-run telemetry banner now records an explicit
"disabled"instead of silently posting"enabled", the English banner copy is rewritten to describe opt-in, and the stale translated copy is removed from the other 17 locales so they fall back to the accurate English text. PRIVACY.md now states telemetry is off by default.Note that a keyless build was already inert (posthog-node throws on an empty key and the client registration is wrapped in try/catch), so this change is about policy: even a keyed build now stays silent until the user explicitly opts in. Cloud gateway telemetry paths are untouched per the decision to leave the gateway as-is.
Tests:
telemetrySettingsTracking.spec.tsupdated to document the new semantics (unset to disabled fires no transition event; unset to enabled fires after enabling), plus a new webview regression test asserting"unset"never initializes PostHog even when an API key and distinct ID are supplied. Ran the touched suites (telemetrySettingsTracking,webviewMessageHandler, webviewTelemetryClient/App),tscforsrcandwebview-ui, and eslint with--prune-suppressionson the edited spec (suppression count did not increase).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.