You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #89 addressing three review findings that landed after the merge.
Dismissing the narrow-terminal sidebar overlay (Escape or backdrop click) used to write the persisted preference to "hide", so the sidebar never auto-appeared again on wide terminals. Dismissal now only clears the transient open signal, and the home toggle no longer leaves the open signal set when the sidebar shows via the wide-terminal preference:
The session route's overlay backdrop gets the same treatment (drops the setSidebar(() => "hide") write).
Also: the home overlay now sets zIndex={1001} so it paints above the content pane and prompt (zIndex={1000}) and receives backdrop clicks, and the slash autocomplete stable-sorts an exact name match to the top so typing /compact selects /compact instead of fuzzy-ranking it against /compact-view.
How did you verify your code works?
Traced the sidebar preference/open-signal state flow in packages/tui/src/routes/home.tsx and packages/tui/src/routes/session/index.tsx to confirm dismissal no longer touches the persisted preference, and confirmed the autocomplete exact-match sort is stable for non-exact entries. CI (typecheck and tests) runs on this PR.
Screenshots / recordings
Terminal-only state fixes (persisted preference, z-index ordering, autocomplete ranking); no visual layout change to capture.
@DevFlex-AI, you've reached your PR review limit, so we couldn't start this review.
Next review available in:48 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
We reviewed changes in aa22f15...76ad509 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.
Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
The reason will be displayed to describe this comment to others. Learn more.
Unknown property 'zIndex' found
React components use JSX, not HTML.
So we need to use JSX attributes and React replicate the respective HTML property/attribute while rendering.
Use of HTML property in JSX can sometimes lead to errors.
For example, class is a keyword in JavaScript (JSX is an extension of JavaScript), so it will throw an error.
However, in HTML it is a valid attribute.
Note: If you use React with Web Components, use the class attribute instead.
The reason will be displayed to describe this comment to others. Learn more.
False positive: this is a SolidJS + opentui TUI <box> element, not React DOM. zIndex is a valid opentui layout prop (used elsewhere in the codebase, e.g. the content pane at zIndex={1000}), so the react/no-unknown-property rule does not apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #104
Type of change
What does this PR do?
Follow-up to #89 addressing three review findings that landed after the merge.
Dismissing the narrow-terminal sidebar overlay (Escape or backdrop click) used to write the persisted preference to
"hide", so the sidebar never auto-appeared again on wide terminals. Dismissal now only clears the transient open signal, and the home toggle no longer leaves the open signal set when the sidebar shows via the wide-terminal preference:The session route's overlay backdrop gets the same treatment (drops the
setSidebar(() => "hide")write).Also: the home overlay now sets
zIndex={1001}so it paints above the content pane and prompt (zIndex={1000}) and receives backdrop clicks, and the slash autocomplete stable-sorts an exact name match to the top so typing/compactselects/compactinstead of fuzzy-ranking it against/compact-view.How did you verify your code works?
Traced the sidebar preference/open-signal state flow in
packages/tui/src/routes/home.tsxandpackages/tui/src/routes/session/index.tsxto confirm dismissal no longer touches the persisted preference, and confirmed the autocomplete exact-match sort is stable for non-exact entries. CI (typecheck and tests) runs on this PR.Screenshots / recordings
Terminal-only state fixes (persisted preference, z-index ordering, autocomplete ranking); no visual layout change to capture.
Checklist