Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #547 +/- ##
===========================================
+ Coverage 99.19% 99.26% +0.06%
===========================================
Files 146 147 +1
Lines 7452 7466 +14
===========================================
+ Hits 7392 7411 +19
+ Misses 60 55 -5
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Thanks for this PR - out of the minor fixes I suggested it looks good. While looking into this, I've seen we don't perform the TLS shutdown when something fails in (MySQL's) handshake, after TLS handshake is performed. I don't think it should be solved in this PR, but if you feel motivated, it's something we should address. |
|
Thanks. Moved TLS shutdown to |
| return error_code(client_errc::bad_handshake_packet_type); | ||
| stored_ec_ = client_errc::bad_handshake_packet_type; | ||
| } | ||
| if (st.tls_active) |
There was a problem hiding this comment.
This is shutting down TLS only if the error comes from the server. On edge cases, we do generate errors, too (e.g. the authentication plugin can report an error). I'd say that doing something like this, but at resume (rather than resume_impl) may help.
close #443
close #231