fix(activity-feed-v2): anchor feed to sidebar to prevent page scroll#4652
Merged
mergify[bot] merged 1 commit intoJun 25, 2026
Merged
Conversation
The v2 wrapper relied on height: 100% propagating from ancestors. On shared-link pages the chain stops at a min-height ancestor, so the feed grew to its content height and the whole page scrolled instead of the feed. Switch the wrapper to position: absolute; inset: 0 and make the outer .bcs-NewActivityFeedContent the containing block, so the feed fills the sidebar regardless of ancestor height behavior.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe activity feed stylesheet now positions the feed absolutely to fill its parent, adds a relative content wrapper, and keeps the existing anchor and SVG reset rules while removing explanatory comments. ChangesActivity Feed V2 Styling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mrscobbler
approved these changes
Jun 25, 2026
jmcbgaston
approved these changes
Jun 25, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 13 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.bcs-NewActivityFeedto its sidebar container withposition: absolute; inset: 0and give.bcs-NewActivityFeedContentposition: relativeso it acts as the containing block.isThreadedRepliesV2Enabledis on.Why
The previous v2 wrapper used
height: 100%, which depends on every ancestor propagating a definite height. The regular preview path runs inside.preview-overlay(position: fixed; inset: 0) which satisfies that. The shared-link path runs inside.shared-file-page->main->bodywhose chain bottoms out at amin-height: 100vhancestor, soheight: 100%collapsed to content height and the feed pushed the page taller than the viewport.Absolutely positioning the wrapper against
.bcs-NewActivityFeedContentmirrors the approach v1 already takes via.bcs-scroll-content-wrapperinSidebarContent.tsx.Test plan
activityFeed.threadedRepliesV2.enabledoff) is unchanged.Summary by CodeRabbit