Skip to content

Snapshots: safer handling of missing snapshots #119

Open

Description

@temp

Part of #101. Line numbers refer to branch chore/php-8.4-dependabot (#98). Verified = reproduced, suspected = from reading the code.

A missing snapshot is created and the test passes, so in CI a snapshot someone forgot to commit gives a green test that asserts nothing. CREATE_SNAPSHOTS=0 exists, but has to be set explicitly.

  • Opt-in: mark the test incomplete or risky when a snapshot was created.
  • Opt-in: refuse to create snapshots when CI is set, unless creation is explicitly allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions