More Misc Tweaks - Flow / Consistency Improvements#65
Conversation
- consistency, capitalization, punctuation - minor rewrites / additions - todo cleanup - 1 or 2 new todos (feedback from my read-through)
Add several missing "next step" directives While reading through the guide I always wanted to at least read the "advanced" considerations and on several of them they left me at a dead-end that I needed to back out of. This change just tries to make the flow consistent for anyone reading the advanced sections.
After fixing the "next steps" flow I just felt the urge to make the whitespace around them consistent.
|
Thanks @janoside! There are merge conflicts and also the spellcheck fails (see |
(flagged some TODOs as coming from me)
|
@mflaxman You're welcome - thanks for all your hard work on this guide. I think everything has been cleaned up and is mergeable now. |
mflaxman
left a comment
mflaxman
left a comment
There was a problem hiding this comment.
This is so good (thanks!) I'm going to merge now. If you want to cleanup some of the nitpick items feel free to submit another PR, or else I will clean them up eventually.
Would you like to be mentioned as a contributor?
| You can read instructions on how to do this [here](https://www.reddit.com/r/Bitcoin/comments/aa3l6n/how_to_check_if_your_electrum_wallet_is_legit/). | ||
|
|
||
|
|
||
| {% include next_steps.md %} |
There was a problem hiding this comment.
Why did you add this? As-is it does nothing. It's the end of the guide, maybe next steps is back to table of contents?
There was a problem hiding this comment.
This was just copied from /emergency-recovery/index.md. Copying from the related "non-advanced" page is what I did for the other missing "next steps" and I just did the same here, not realizing it didn't really apply!
|
|
||
| #### Cannot Buy Assembled Version | ||
| While the DIY version is great for expert users (and no longer requires soldiering!), the overwhelming majority of users prefer a product they can purchase. | ||
| While the DIY version is great for expert users (and no longer requires soldering!), the overwhelming majority of users prefer a product they can purchase. |
|
|
||
| * Abstracts away a lot of multisig's complexity | ||
| * Holds `1` (or more) of your seeds | ||
| * Holds 1 (or more) of your seeds |
There was a problem hiding this comment.
The convention in the guide has been to use code formatting for m-of-n, do you think that's bad? I like it, but consistency is probably the most important. IThere are other examples that show it as 1 above on this very page.
There was a problem hiding this comment.
I do like the code formatting for quorum descriptions (e.g. 2-of-3). I'm on the fence about using it for individual numbers but, regardless, I agree consistency is more important and that convention is used elsewhere (I just didn't register the few other uses).
PR incoming...
| 1. Specter on your host computer (malware) displays a `2-of-3` receiving address, where *none* of your hardware wallets are actually part of the multisig scheme. | ||
| 1. You pull out hardware wallet A (also malware!) and it (falsely) confirms the same receive address on its trusted display. | ||
| 1. Specter-Desktop on your host computer (assumed to be malware infected) displays a `2-of-3` receiving address, where *none* of your hardware wallets are actually part of the multisig scheme. | ||
| 1. You pull out hardware wallet A (also malware infected!) and it (falsely) confirms the same receive address on its trusted display. |
There was a problem hiding this comment.
This is not your fault, but what I wrote here is confusing. I'm going to rework this.
| Read more about known issues with Coldcard [here](/known-issues/hardware/coldcard). | ||
|
|
||
|
|
||
| {% include next_steps.md next_url="coordinate-multisig" next_name="Coordinate Multisig" %} |
| Read more about known issues with SeedPicker [here](/known-issues/software/seedpicker). | ||
|
|
||
|
|
||
| {% include next_steps.md next_url="cobo" next_name="Setup Cobo Vault" %} |
|
I'm happy to help! No need for contributor call-out, but thank you. |
2 participants
This is another dump of misc tweaks in the same spirit as PR #62, gathered as I finished my read-through.