Skip to content

overlay: deduplicate arrays during deep merge - #791

Merged
paulRbr merged 1 commit into
bump-sh:mainfrom
garciasdos:main
Feb 23, 2026
Merged

overlay: deduplicate arrays during deep merge#791
paulRbr merged 1 commit into
bump-sh:mainfrom
garciasdos:main

Conversation

@garciasdos

@garciasdos garciasdos commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #792

@garciasdos garciasdos mentioned this pull request Feb 5, 2026
Open
@garciasdos
garciasdos marked this pull request as ready for review February 5, 2026 11:06
fbraure
fbraure previously approved these changes Feb 5, 2026
View reviewed changes

@fbraure fbraure left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@garciasdos

garciasdos commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

Hey @fbraure when can I expect this to be merged? Thanks 🙏🏼

@fbraure

fbraure commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Hey @fbraure when can I expect this to be merged? Thanks 🙏🏼

Hey @garciasdos !
I see there is a pending question. As soon as the discussion is solved, we will merge it.
We are planning a release in the coming days.

@paulRbr
paulRbr dismissed fbraure’s stale review February 13, 2026 10:46

I'm removing the approval since I don't understand the problem being solved with this PR.

@paulRbr
paulRbr enabled auto-merge February 23, 2026 16:18
paulRbr
paulRbr approved these changes Feb 23, 2026
View reviewed changes

@paulRbr paulRbr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@paulRbr
paulRbr merged commit d52d816 into bump-sh:main Feb 23, 2026
9 checks passed
@fbraure fbraure mentioned this pull request Apr 20, 2026
Merged
fbraure added a commit that referenced this pull request Apr 22, 2026
@fbraure
Fix arrays vs enum merge
2b9dadc 
Add an `afterEach` parameter to the `mergician` function to ensure:
 - Arrays are appended (not deduped)
 - Enums are deduped

Fixes #818 (arrays deduped) with an evolution of #791 (deduplicate enum)
fbraure added a commit that referenced this pull request Apr 22, 2026
@fbraure
Fix arrays vs enum merge
496033e 
Add an `afterEach` parameter to the `mergician` function to ensure:
 - Arrays are appended (not deduped)
 - Enums are deduped

Fixes #818 (arrays deduped) with an evolution of #791 (deduplicate enum)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulRbr paulRbr paulRbr approved these changes
@fbraure fbraure fbraure left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[overlay] incorrectly concatenates enum arrays during deep merge

3 participants

@garciasdos @fbraure @paulRbr