enable cargo-component lock files - #124
Closed
macovedj wants to merge 5 commits into
Closed
Conversation
macovedj
force-pushed
the
cargo-component-lock
branch
from
November 20, 2024 18:06
2caea88 to
150f64e
Compare
macovedj
force-pushed
the
cargo-component-lock
branch
from
November 20, 2024 18:09
c73a472 to
e240f39
Compare
macovedj
marked this pull request as ready for review
November 20, 2024 19:22
Author
|
@thomastaylor312 @calvinrp @lann ready for review |
Contributor
|
Hey as we've certainly come a long way since this PR (and cargo-component is no longer the suggested way of building Rust components, etc), I'm going to close this out! Happy to re-open if there's some interest in rewriting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes bring logic from cargo-component so that dependency resolution can be fully sourced from wasm-pkg-tools in cargo-component. Namely, cargo-component can use wkg.lock instead of Cargo-component.lock