Repository navigation
reverseproxy: Honor health check redirect destinations - #8223
Merged
steadytao merged 1 commit intoOct 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8222
Active health checks with
follow_redirectsenabled followed the redirect path and updated the Host header, but continued connecting to the original upstream address.For example, if backend A redirected its health check to backend B, Caddy requested B’s path from A instead. Depending on A’s response, this could remove a healthy backend from service or leave an unhealthy backend available.
This change clears the original dialing override when a redirect changes the scheme or host/port, allowing the transport to connect to the redirect destination. Same-origin redirects and redirects returning to the original origin retain the original override.
Six regression cases cover healthy and unhealthy redirect targets, HTTPS, relative redirects, redirects back to the original origin, and disabled redirect following.
Validation:
go test -race -short ./...go build ./...go vet ./...AI disclosure: I wrote the fix. The regression tests were generated with GPT-6.1 and I reviewed them.