Repository navigation
Release Review: DeviceDataVolume r2.1 (rc Sync26) - #108
camara-release-automation[bot] wants to merge 4 commits into
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
Updated API definitions to address CAMARA validation warnings, added pagination support for subscriptions, and renamed data allowance consumption events for clarity. Refactored device-data-volume to return data volumes instead of categories and added lastStatusTime field to responses.
There was a problem hiding this comment.
Hi team, apologies for the delay.
Many thanks for incorporating the review feedback. it looks great !
A few comments :
In the device-data-volume-subscriptions.feature file,
- the names of the notifications have not been updated (lines 138, 150, ...)
- the 10 and 00 percent test cases are missing (if this needs to be complete)
- the new "unlimited" value is not present in the test use cases
In the device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscriptionList.feature file:
- some error test cases seem to be missing
hdamker
left a comment
There was a problem hiding this comment.
One blocking issue, found by Claude Code:
Test definition file is missing its .feature extension — code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscriptionList (also on main; introduced by PR #103). Two consequences, each verified:
- Skipped by the snapshot version rewrite. It still says vwip at line 2 and {apiroot}/device-data-volume-subscriptions/vwip/subscriptions at line 18. Every other artifact says 0.2.0-rc.1 / v0.2rc1 (the OpenAPI servers.url). The other three .feature files were rewritten correctly.
- Skipped by CAMARA Validation. The PASS (0 errors, 0 warnings, 0 hints) is not evidence this file is clean — the Gherkin linter globs *.feature and never opened it.
That's a bug which can't be deferred, as the release would be incorrect. The fix is just the rename. But it has to be done on main, so requires a discard/re-create snapshot cycle.
|
FYI: This snapshot was created before camaraproject/tooling#431 got active with tooling release v0.10.0. #431 moved the automated README Release Information update from the release-review branch onto the snapshot branch. The merge commit above brings this branch in line with that: the README update now lives on the snapshot branch, so this branch differs from it by the CHANGELOG only. No content change. |
|
@maxl2287 @sachinvodafone Please see my comment above and the related issue #109 I created. Please try to address the issue before Tuesday September 15th, 15:00 UTC. |
Release Review: r2.1 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.2.0-rc.10.1.00.2.0-rc.10.1.0Dependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r2.1-71bfba2