Skip to content

Release Review: DeviceDataVolume r2.1 (rc Sync26) - #108

Closed
camara-release-automation[bot] wants to merge 4 commits into
release-snapshot/r2.1-71bfba2from
release-review/r2.1-71bfba2
Closed

camara-release-automation[bot] wants to merge 4 commits into
release-snapshot/r2.1-71bfba2from
release-review/r2.1-71bfba2

Conversation

@camara-release-automation

@camara-release-automation camara-release-automation Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Release Review: r2.1 rc

This PR finalizes the reviewable release content for the active snapshot.

Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.

Release contents

API Version Status Comparison target
device-data-volume-subscriptions 0.2.0-rc.1 rc 0.1.0
device-data-volume 0.2.0-rc.1 rc 0.1.0

Dependencies: Commonalities r4.3, ICM r4.2

Codeowner Actions

Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.

  • Update the CHANGELOG

    What to do:

    • Copy all API-consumer-relevant changes from the provided list into the appropriate Breaking changes / Added / Changed / Fixed / Removed sections for each API. List breaking changes both in Breaking changes and in their normal change category.
    • Do not copy administrative, tooling-only, or internal maintenance changes unless they affect API consumers.
    • For each API, fill the CHANGELOG against the stated comparison target, following the release-type rules at the top of the CHANGELOG.
  • Document deferred validation warnings (and hints)

    What to do:

    • Check the CAMARA Validation comment on this PR for warnings and hints.
    • For each warning you do not fix, document it in an issue: include a copy of the validation summary line(s) and the reason the fix is deferred.
    • Document in the same way any validation hint that is applicable to the API and needs to be fixed later.
    • You may group several findings into one issue or split them across issues — either is fine.
    • List the documenting issue(s) in a comment on this PR.
    • Note: documenting deferred warnings is optional but recommended for alpha pre-releases, and mandatory for rc pre-releases and public releases.
  • The release is ready for Release Management review

    Check that:

    • All mandatory release assets for the declared status(es) are present (see the table below "Required release assets per API status" by expanding the arrow);
    • API documentation and test cases are adequate for the target status.

    Tick this box to confirm readiness and to start the Release Management review.

Release Management Actions

The following actions and checks are done by a Release Management reviewer before approving the PR:

  • Assign the Release Management reviewer(s) as assignee(s) of this PR
  • CHANGELOG follows the release documentation rules
  • Breaking changes are documented and version updates follow SemVer rules
  • Mandatory release assets are present for each API according to its status
  • All remaining validation warnings are documented in issues and the reasons for deferral are defensible
Required release assets per API status
Nr Asset alpha rc initial
public
stable
public
1 Release Plan M M M M
2 API Definition(s) M M M M
3 Commonalities compliance O M M M
4 API Documentation M M M M
5 User Stories O O O M
6 Test Cases (basic) O M M M
7 Test Cases (enhanced) O O O M
8 API Description O O M M

M = Mandatory, O = Optional — Full documentation

Valid next actions for codeowners

  • Merge this PR when all Codeowner Actions and Release Management Actions are complete and the required approvals are present — creates the draft release
  • Use /discard-snapshot <reason> in the Release Issue to discard this snapshot, return to planned, and update content on main

Snapshot: r2.1-71bfba2

@camara-validation

camara-validation Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

Updated API definitions to address CAMARA validation warnings, added pagination support for subscriptions, and renamed data allowance consumption events for clarity. Refactored device-data-volume to return data volumes instead of categories and added lastStatusTime field to responses.
@tanjadegroot tanjadegroot self-assigned this Sep 1, 2026

@tanjadegroot tanjadegroot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team, apologies for the delay.

Many thanks for incorporating the review feedback. it looks great !

A few comments :

In the device-data-volume-subscriptions.feature file,

  • the names of the notifications have not been updated (lines 138, 150, ...)
  • the 10 and 00 percent test cases are missing (if this needs to be complete)
  • the new "unlimited" value is not present in the test use cases

In the device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscriptionList.feature file:

  • some error test cases seem to be missing

@hdamker hdamker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking issue, found by Claude Code:

Test definition file is missing its .feature extension — code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscriptionList (also on main; introduced by PR #103). Two consequences, each verified:

  • Skipped by the snapshot version rewrite. It still says vwip at line 2 and {apiroot}/device-data-volume-subscriptions/vwip/subscriptions at line 18. Every other artifact says 0.2.0-rc.1 / v0.2rc1 (the OpenAPI servers.url). The other three .feature files were rewritten correctly.
  • Skipped by CAMARA Validation. The PASS (0 errors, 0 warnings, 0 hints) is not evidence this file is clean — the Gherkin linter globs *.feature and never opened it.

That's a bug which can't be deferred, as the release would be incorrect. The fix is just the rename. But it has to be done on main, so requires a discard/re-create snapshot cycle.

@hdamker

hdamker commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

FYI: This snapshot was created before camaraproject/tooling#431 got active with tooling release v0.10.0. #431 moved the automated README Release Information update from the release-review branch onto the snapshot branch. The merge commit above brings this branch in line with that: the README update now lives on the snapshot branch, so this branch differs from it by the CHANGELOG only. No content change.

@hdamker

hdamker commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

@maxl2287 @sachinvodafone Please see my comment above and the related issue #109 I created. Please try to address the issue before Tuesday September 15th, 15:00 UTC.

@camara-release-automation
camara-release-automation Bot deleted the release-review/r2.1-71bfba2 branch September 14, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants