Skip to content

[Fix] Correct feature file name and event names / schemas within feature files #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-murray merged 3 commits into from
Sep 14, 2026
+8 −8
Merged

[Fix] Correct feature file name and event names / schemas within feature files #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a40ad21
Rename device-data-volume-subscriptions-retrieveDeviceDataVolumeSubsc…
eric-murray Sep 14, 2026
03e912d
Fix event names in tests
eric-murray Sep 14, 2026
09a15d0
Update event schema names used for tests
eric-murray Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...-retrieveDeviceDataVolumeSubscriptionList → ...eDeviceDataVolumeSubscriptionList.feature
View file
Open in desktop
File renamed without changes.
16 changes: 8 additions & 8 deletions code/Test_definitions/device-data-volume-subscriptions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ Feature: Device Data Volume Subscriptions API, vwip - Operations createDeviceDat
And the subscription property "$.types" contains the element "org.camaraproject.device-data-volume-subscriptions.v0.data-50-percent-remaining"
And the subscription property "$.sink" is a valid callback URL
When the device's data volume consumed 50% of the data plan
Then event notification "data-50-percent" is sent to the specified callback URL
Then event notification "data-50-percent-remaining" is sent to the specified callback URL
And the sink credentials specified when the subscription was created are included
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage50Percent"
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage50PercentRemaining"
And the notification property "$.type" is equal to "org.camaraproject.device-data-volume-subscriptions.v0.data-50-percent-remaining"
And the notification property "$.data.subscriptionId" is equal to "id"

Expand All @@ -147,9 +147,9 @@ Feature: Device Data Volume Subscriptions API, vwip - Operations createDeviceDat
And the subscription property "$.types" contains the element "org.camaraproject.device-data-volume-subscriptions.v0.data-25-percent-remaining"
And the subscription property "$.sink" is a valid callback URL
When the device's data volume consumed 75% of the data plan
Then event notification "data-75-percent" is sent to the specified callback URL
Then event notification "data-25-percent-remaining" is sent to the specified callback URL
And the sink credentials specified when the subscription was created are included
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage75Percent"
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage25PercentRemaining"
And the notification property "$.type" is equal to "org.camaraproject.device-data-volume-subscriptions.v0.data-25-percent-remaining"
And the notification property "$.data.subscriptionId" is equal to "id"

Expand All @@ -159,9 +159,9 @@ Feature: Device Data Volume Subscriptions API, vwip - Operations createDeviceDat
And the subscription property "$.types" contains the element "org.camaraproject.device-data-volume-subscriptions.v0.data-10-percent-remaining"
And the subscription property "$.sink" is a valid callback URL
When the device's data volume consumed 90% of the data plan
Then event notification "data-90-percent" is sent to the specified callback URL
Then event notification "data-10-percent-remaining" is sent to the specified callback URL
And the sink credentials specified when the subscription was created are included
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage90Percent"
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage10PercentRemaining"
And the notification property "$.type" is equal to "org.camaraproject.device-data-volume-subscriptions.v0.data-10-percent-remaining"
And the notification property "$.data.subscriptionId" is equal to "id"

Expand All @@ -171,9 +171,9 @@ Feature: Device Data Volume Subscriptions API, vwip - Operations createDeviceDat
And the subscription property "$.types" contains the element "org.camaraproject.device-data-volume-subscriptions.v0.data-00-percent-remaining"
And the subscription property "$.sink" is a valid callback URL
When the device's data plan is exceeded
Then event notification "data-exceeded" is sent to the specified callback URL
Then event notification "data-00-percent-remaining" is sent to the specified callback URL
And the sink credentials specified when the subscription was created are included
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage90Percent"
And notification body complies with the OAS schema at "#/components/schemas/EventDataUsage00PercentRemaining"
And the notification property "$.type" is equal to "org.camaraproject.device-data-volume-subscriptions.v0.data-00-percent-remaining"
And the notification property "$.data.subscriptionId" is equal to "id"

Expand Down