fix(dns-scanner): extended CNAME/NS results#7442
Open
lcampbell2 wants to merge 6 commits into
Open
Conversation
lcampbell2
changed the title
FestiveKyle
reviewed
Jul 9, 2026
| return ns_ip | ||
|
|
||
|
|
||
| def check_ns_delegations(domain, zone_apex, ns_records, resolver=None, timeout_sec=10): |
Collaborator
There was a problem hiding this comment.
I'm having trouble getting this to flag a real lame nameserver, do you have a working domain I can test it against?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve DNS scanner output for takeover/hijack detection by fixing NS direct-query evidence and adding per-query DNS response codes. This updates the scan payload to better support CNAME and Sitting Duck classification while preserving current scan flow.
query_reswith per-record-type DNS rcodes (A, SOA, NS, CNAME).lame_type(none/partial/full).