retry removing finalizer from app cr #417

Activity

1. cppforlife

   added

   enhancementThis issue is a feature requestThis issue is a feature request

   carvel-triageThis issue has not yet been reviewed for validityThis issue has not yet been reviewed for validity

   on Oct 29, 2021
2. danielhelfand commented on Nov 1, 2021

   

   danielhelfand

   on Nov 1, 2021

   Contributor

   More actions

   Delete failed: Unblocking for deploy: Updating app: Operation cannot be fulfilled on apps.kappctrl.k14s.io "xxx": the object has been modified; please apply your changes to the latest version and try again

   Do we have any details on how to reproduce this error?

   lets put in a retry behaviour for finalizer removal for both pkgr and app.

   We should always retry, or is there a way to isolate this to a specific case?

   For the App CR, the finalizer removal func is located here: https://github.com/vmware-tanzu/carvel-kapp-controller/blob/4b0307d377e429c00d8f5cf6499bf59989f71f44/pkg/app/crd_app.go#L63

   For the PackageRepository, the finalizer removal func is here: https://github.com/vmware-tanzu/carvel-kapp-controller/blob/f30b42e0cbeb72e3b29f50a496abbc956c35c5de/pkg/pkgrepository/crd_app.go#L60
3. cppforlife commented on Nov 4, 2021

   

   cppforlife

   on Nov 4, 2021

   ContributorAuthor

   More actions

   Do we have any details on how to reproduce this error?

   i dont have any specific repro scenarios (i was just deleting a package that installed other packages). i imagine it's either kapp-controller doing some updates, or just some other controller.

   We should always retry, or is there a way to isolate this to a specific case?

   i think we should be able to isolate retry logic just for unblock* methods.
4. danielhelfand

   added

   carvel-acceptedThis issue should be considered for future work and that the triage process has been completedThis issue should be considered for future work and that the triage process has been completed

   and removed

   carvel-triageThis issue has not yet been reviewed for validityThis issue has not yet been reviewed for validity

   on Nov 22, 2021
5. danielhelfand commented on Nov 22, 2021

   

   danielhelfand

   on Nov 22, 2021

   Contributor

   More actions

   I think it would still be worthwhile to identify a way to consistently reproduce this. Any further thoughts you can provide on this would help.

   i think we should be able to isolate retry logic just for unblock* methods.

   Sounds reasonable to me though.
6. aaronshurley

   added this to Carvelon Jul 7, 2022
7. aaronshurley

   moved this to To Triage in Carvelon Aug 18, 2022
8. praveenrewar

   added this to Carvelon Feb 14, 2023
9. github-project-automation

   moved this to To Triage in Carvelon Feb 14, 2023
10. neil-hickey

    moved this from To Triage to Unprioritized in Carvelon Feb 22, 2023
11. neil-hickey

    added

    priority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.

    bugThis issue describes a defect or unexpected behaviorThis issue describes a defect or unexpected behavior

    on Feb 22, 2023