Skip to content

DNM : Bump/dep/test kind - #1830

Open
sameerforge wants to merge 2 commits into
carvel-dev:developfrom
sameerforge:bump/dep/test-kind
Open

sameerforge wants to merge 2 commits into
carvel-dev:developfrom
sameerforge:bump/dep/test-kind

Conversation

@sameerforge

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@sameerforge
sameerforge force-pushed the bump/dep/test-kind branch 3 times, most recently from aff651b to edfe506 Compare May 20, 2026 06:15
sameerforge and others added 2 commits July 16, 2026 15:49
Signed-off-by: Sameer <sameer.khan@broadcom.com>
The packaging aggregated API server is a thin proxy whose storage is the
host cluster's InternalPackage(Metadata) CRDs, and its custom REST watch
does not synthesize the WatchList "initial-events-end" bookmark.

With WatchList enabled, the embedded apiserver's SetListOptionsDefaults
injects sendInitialEvents + resourceVersionMatch=NotOlderThan into watch
requests with resourceVersion=0. Host clusters that ship the WatchList
feature gate disabled (e.g. Kubernetes 1.33, which turned it off by
default) then reject the forwarded options with 422 Unprocessable Entity,
failing a plain "watch&resourceVersion=0" (TestK8APIEndpoints).

Disabling the feature gate in the packaging apiserver process fixes this
across every host version: raw watch&resourceVersion=0 requests are served
as a plain watch (no injection), and WatchList-capable clients (client-go
informers) receive a 422 for the streaming request and transparently fall
back to list+watch.

Note: an earlier approach that stripped these options only in the REST
watch path was rejected because it returned a successful watch stream with
no bookmark, which hangs WatchList informers (including kapp-controller's
own) and stalls the shared manager cache.

Signed-off-by: Sameer <sameer.khan@broadcom.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Sameer <sameer.khan@broadcom.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant