Skip to content

docs(friedland): add chapter 9 exhibit IV, V, VI and complete exhibits I-III - #1197

Open
priyam0k wants to merge 18 commits into
mainfrom
friedland/chapter-9-exhibit-iv
Open

docs(friedland): add chapter 9 exhibit IV, V, VI and complete exhibits I-III#1197
priyam0k wants to merge 18 commits into
mainfrom
friedland/chapter-9-exhibit-iv

Conversation

@priyam0k

@priyam0k priyam0k commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

  • added exhibit IV (us auto product mix study) to chapter 9 notebook using friedland_us_auto
  • updated exhibit I, II and III tables with complete columns, plus sheets 3 and 4 for exhibit II
  • updated assertions to check reported and paid ibnr across scenarios
  • updated code to use implicit_axis=True for age extraction and clean .to_frame() series calls per feedback
  • added exhibit V (sheets 1 and 2) for us pp auto using the gunnar benktander method
  • added exhibit VI (sheets 1 and 2) for us auto using the gunnar benktander method
  • add own distinct Column Notes block and total rows across all exhibits

Related GitHub Issue(s)

#588

Additional Context for Reviewers

keeping this PR in draft for now. will look into adding exhibit V and VI for chapter 9 covering unpaid claim estimates using the benktander method.

Checklist

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)

Note

Low Risk
Documentation-only changes in a Friedland tutorial notebook; no library API or production reserving logic is modified.

Overview
Extends docs/friedland/chapter_9.ipynb so Friedland Chapter 9 now covers Exhibits I–VI: full BF projection and unpaid tables for industry auto, XYZ, and PP scenarios, plus Exhibit IV (U.S. auto product mix via friedland_us_auto) and Exhibits V & VI (Gunnar Benktander unpaid estimates for the PP and U.S. auto scenarios).

Exhibits I–III gain the missing table columns, additional sheets (e.g. Exhibit II sheets 3–4), per-exhibit Column Notes, add_total_row on displays, and reconciliation assert checks for reported/paid IBNR and related totals.

Notebook code is aligned with prior review feedback: accident-year age comes from latest_diagonal.to_frame(keepdims=True, implicit_axis=True, ...), and one-dimensional triangle extracts use consistent .to_frame(origin_as_datetime=False).squeeze() instead of ad hoc series handling.

Reviewed by Cursor Bugbot for commit 1c50ba7. Bugbot is set up for automated code reviews on this repo. Configure here.

@priyam0k
priyam0k marked this pull request as draft August 8, 2026 06:14
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 14.9% of exported symbols fully typed (197 / 1323)

Known Ambiguous Unknown Total
Project (head) 197 111 1015 1323

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 316
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

Comment thread docs/friedland/chapter_9.ipynb Outdated
@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.47%. Comparing base (f7f08e8) to head (1c50ba7).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   91.25%   91.47%   +0.22%     
==========================================
  Files          91       91              
  Lines        5395     5664     +269     
  Branches      688      766      +78     
==========================================
+ Hits         4923     5181     +258     
- Misses        338      343       +5     
- Partials      134      140       +6     
Flag Coverage Δ
unittests 91.45% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread docs/friedland/chapter_9.ipynb
Comment thread docs/friedland/chapter_9.ipynb
@priyam0k priyam0k changed the title docs(friedland): add chapter 9 exhibit IV and complete exhibits I-III docs(friedland): add chapter 9 exhibit IV, V, VI and complete exhibits I-III Aug 10, 2026
@priyam0k
priyam0k force-pushed the friedland/chapter-9-exhibit-iv branch from 0d582d1 to 645d24d Compare August 10, 2026 04:04
@priyam0k
priyam0k force-pushed the friedland/chapter-9-exhibit-iv branch from 645d24d to 4d26f54 Compare August 10, 2026 06:38
Comment thread docs/friedland/chapter_9.ipynb
Comment thread docs/friedland/chapter_9.ipynb Outdated
Comment thread docs/friedland/chapter_9.ipynb Outdated
Comment thread docs/friedland/chapter_9.ipynb Outdated
Comment thread docs/friedland/chapter_9.ipynb Outdated
Comment thread docs/friedland/chapter_9.ipynb Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4ce7985. Configure here.

Comment thread docs/friedland/chapter_9.ipynb Outdated
@priyam0k
priyam0k marked this pull request as ready for review August 11, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant