Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
+ Coverage 91.25% 91.53% +0.28%
==========================================
Files 91 91
Lines 5395 5575 +180
Branches 688 717 +29
==========================================
+ Hits 4923 5103 +180
Misses 338 338
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Good news - you can simply uncheck "Run Git hooks" when making a tiny non-breaking change to bypass running the whole suite locally. For example, say you're working on an issue and get 99% of the work done. You run the pre-commit checks by default. But then you've got some minor edits (like removing a comment), which you can push immediately by unchecking "Run Git hooks" or whatever your IDE equivalent is. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8e94531. Configure here.
|
Running |
where is this checkbox? can you attach a screenshot |

Summary of Changes
Adds Ruff and pre-commit to workflows.
Related GitHub Issue(s)
#651
Additional Context for Reviewers
Try out pre-commit and let me know what you think. Already, I'm seeing that it's a little annoying if you want to push small changes that you know will pass - for example, I removed some verbose comments that Claude left behind, but all the checks ran again prior to push, taking an extra 4 minutes for a very trivial change.
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Tooling and lint configuration only; no runtime library behavior changes beyond removing unused test imports.
Overview
Introduces Ruff (Pyflakes/pycodestyle subset E4/E7/E9/F) as required CI and optional local gates, without forcing a repo-wide cleanup in one shot.
CI: A new Ruff workflow runs on pushes and PRs, linting only changed
*.pyfiles. It runsruff checkwith per-file-ignores cleared (lint.per-file-ignores={}), so edited files must meet the full rule set even thoughpyproject.tomlstill lists grandfathered ignores for untouched legacy files.Local: pre-commit installs pre-commit and pre-push hooks: Ruff on push (same empty per-file-ignores override) and full
uv run pyteston every push.Config:
ruffandpre-commitare added to the dev optional dependencies;uv.lockis updated accordingly. One test file drops unused imports after lint touched it.Reviewed by Cursor Bugbot for commit f40ee9d. Bugbot is set up for automated code reviews on this repo. Configure here.