Conversation
Detect SID and QBT_SID_<port> cookies returned by qBittorrent.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the qBittorrent homepage connection code to support the session-cookie naming introduced in qBittorrent 5.2+.
Problem
The connection code assumes the session cookie is always named
SID. qBittorrent 5.2+ returns a port-specific cookie such asQBT_SID_8080, causing an undefined cookie lookup and HTTP 500 error, as references #2060Change
The returned cookies are searched for either:
SIDQBT_SID_The exact returned cookie name and value are then used in the API request.
Testing
Tested successfully with: