Skip to content

ConsoleZ closes without explanation on bad config #358

Closed

Description

@Whiteknight

If the config in console.xml is invalid, the ConsoleZ program will close immediately with no error message or indication of the problem.

I have seen this problem in three scenarios at different times (the third being the most recent):

  1. XML formatting errors (unclosed tags, caused by bad copy)
  2. XML structure changes (caused by copying an old console.xml to a new install)
  3. Missing shell exe (caused by an upgrade to new msysgit, which installed to a new path)

In all three cases, some kind of error message about what the error is and (even better) what could be done to correct the issue would be helpful.

Allowing the program to open with some default config while the issue is being addressed would also be helpful.

Activity

  1. cbucher commented on Aug 4, 2016

    @cbucher
    Owner

    I have seen this problem in three scenarios at different times (the third being the most recent):

    1. XML formatting errors (unclosed tags, caused by bad copy)

    This case only occurs when user modify the configuration file by himself.
    Last versions of ConsoleZ start by ignoring the corrupt file. I can add an error message popup too.

    1. XML structure changes (caused by copying an old console.xml to a new install)

    Strange... configuration file is always backward compatible. I can use my current configuration file with the old Console2 application. And I can use Console2 configuration file with every ConsoleZ version.

    1. Missing shell exe (caused by an upgrade to new msysgit, which installed to a new path)

    Yes we can start a failover shell when zero shell has started.

  2. self-assigned this
    on Aug 4, 2016
  3. Whiteknight commented on Aug 4, 2016

    @Whiteknight
    Author

    Case #2 might also be related to Case #1 so we can probably ignore it. Having an error popup in case the file is unreadable for any reason would be a huge help.

  4. cbucher commented on Aug 5, 2016

    @cbucher
    Owner

    If you start ConsoleZ with a broken configuration file, you will use default configuration. So when you save the configuration (by editing settings, selecting views, …), broken file is replaced by new one.
    Should we (only when configuration file is broken):

    • ask for replacement when saving the configuration file?
    • backup the configfuration file?
    • just add a notice in the warning popup?
  5. added 5 commits that reference this issue on Aug 8, 2016
  6. cbucher commented on Aug 18, 2016

    @cbucher
    Owner
  7. added this to the 1.17.1 milestone on Aug 19, 2016
  8. cbucher commented on Aug 23, 2016

    @cbucher
    Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions