Improve resolving references, cache loaded files in current context #13

Activity

1. cebe

   added

   enhancementNew feature or requestNew feature or request

   on Nov 22, 2018
2. cebe commented on Nov 22, 2018

   

   cebe

   on Nov 22, 2018

   OwnerAuthor

   More actions

   php-openapi/src/spec/Reference.php

   Line 107 in 4a4892d

   // TODO could be a good idea to cache loaded files in current context to avoid loading the same files over and over again
3. coatesap commented on Dec 13, 2019

   

   coatesap

   on Dec 13, 2019

   More actions

   I have a feeling this lack of caching is the biggest performance burden when reading API files. As an experiment, I ran Speccy's resolve command over my API file first (which took ~1 sec). Using the resolved output from Speccy dropped the time of Reader::readFromYamlFile() down from 24 seconds to 10 seconds, which is fairly significant.

   👍React with 👍1Reacted by Carsten Brandt
4. cebe

   added this to the 1.5.0 milestone on Mar 10, 2020
5. cebe

   closed this as completedin #67on Dec 14, 2020