Repository navigation
Revert "chore(deps): update junit-framework monorepo to v6 (#370)" - #395
Closed
algomaster99 wants to merge 1 commit into
Closed
algomaster99 wants to merge 1 commit into
algomaster99 wants to merge 1 commit into
Conversation
JUnit 6 requires Java 17 at runtime, which breaks the tests-on-11 job (UnsupportedClassVersionError on org.junit.platform.launcher.TagFilter). This reverts commit 2a80838. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #370 (JUnit 6.1.3 → 5.14.2).
JUnit 6 requires Java 17 at runtime, but
tests-on-11builds with JDK 21 and then runsmvn surefire:teston JDK 11. With JUnit 6 on the classpath, surefire fails before any test runs:This went unnoticed because CI on
mainhas been failing withstartup_failure(unpinned actions, fixed in #394).Follow-up: add a Renovate rule to keep
org.juniton 5.x while Java 11 is supported, otherwise Renovate will reopen the v6 bump.🤖 Generated with Claude Code