Skip to content

feat: Choose one identifier when a record lists several - #20

Merged
chmodas merged 1 commit into
trunkfrom
b-13
Oct 29, 2026
Merged

chmodas merged 1 commit into
trunkfrom
b-13

Conversation

@chmodas

@chmodas chmodas commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Records that list several ISBNs or ISSNs now keep the lowest one, compared by its digits and stripped of labels such as "(Print)", in every format. The others are kept in the format's extras ("ris:SN", "nbib:IS", "endnote:isbn", "bibtex:isbn" or "bibtex:issn", and the CSV column) and written back out, so the identifier no longer depends on which value a format happens to keep, and one article exported in two formats gets the same identifier. A BibTeX issn beside an isbn is now kept in extras instead of being dropped.

Records that list several ISBNs or ISSNs now keep the lowest one,
compared by its digits and stripped of labels such as "(Print)", in
every format. The others are kept in the format's extras ("ris:SN",
"nbib:IS", "endnote:isbn", "bibtex:isbn" or "bibtex:issn", and the
CSV column) and written back out, so the identifier no longer depends
on which value a format happens to keep, and one article exported in
two formats gets the same identifier. A BibTeX issn beside an isbn is
now kept in extras instead of being dropped.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.94%. Comparing base (c408466) to head (cd03377).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk      #20      +/-   ##
==========================================
+ Coverage   99.86%   99.94%   +0.07%     
==========================================
  Files          11       12       +1     
  Lines        3060     3514     +454     
==========================================
+ Hits         3056     3512     +456     
+ Misses          4        2       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chmodas
chmodas merged commit fba22e2 into trunk Oct 29, 2026
3 checks passed
@chmodas
chmodas deleted the b-13 branch October 29, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants