You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use owner-neutral wording for MCP approval notes #34
Hosted Code Review on PR #29 reported P2 wording that names Chris in the t3_pending_request note description. The user guide describes the note as the caller's statement of what the user said. This is a portability follow-up: the current deployment is Chris's personal fork, where the name matches the approved request.
Source: #29 (comment)
Reviewed head: 6f1debb
Root cause: mcp-approval-note-owner-name
Owner: the maintainer of the outside-agent approval interface.
Use owner-neutral wording if this interface is used outside Chris's personal installation. Keep the note a caller statement, and preserve the full-access caller checks and all audit fields. This follow-up must not expand approval authority or create standing grants.
Acceptance: the model-facing description and user guide agree about the note's meaning, and the measured tool-description budget remains accurate. Validate the generated tool schema and focused approval tests. The wording can be reverted without changing stored records or authorization behavior.
Status: still valid, low priority. The t3_pending_request description still reads "what the caller says Chris said" (apps/server/src/mcp/toolkits/thread/tools.ts). Only matters if this interface is used outside this fork. No ledger row.
Triage by the round-four GitHub hygiene pass (ledger key r4/w7-github), 2026-11-13. Left open.
Activity
chrisohearn commentedon Nov 13, 2026
Status: still valid, low priority. The
t3_pending_requestdescription still reads "what the caller says Chris said" (apps/server/src/mcp/toolkits/thread/tools.ts). Only matters if this interface is used outside this fork. No ledger row.Triage by the round-four GitHub hygiene pass (ledger key
r4/w7-github), 2026-11-13. Left open.