Skip to content

Show correct line numbers. - #70

Merged
meshy merged 3 commits into
masterfrom
fix-line-numbers
Jun 13, 2013
Merged

Show correct line numbers.#70
meshy merged 3 commits into
masterfrom
fix-line-numbers

Conversation

@mlen108

@mlen108 mlen108 commented Jun 5, 2013

Copy link
Copy Markdown

We're storing the line number of each Method now, so we should be showing the correct line numbers. We may need to do some giggery pokery with pygment, as it's generated with this line.

{% pygment %}<pre lang="python" class="code">{{ namesake.code }}</pre>{% endpygment %}

@ghost ghost assigned mlen108 May 18, 2013
@mlen108

mlen108 commented Jun 5, 2013

Copy link
Copy Markdown

Looks like this
http://img10.imageshack.us/img10/1197/49658397.png

@mlen108

mlen108 commented Jun 5, 2013

Copy link
Copy Markdown

@meshy ^^

@meshy

meshy commented Jun 6, 2013

Copy link
Copy Markdown
Contributor Author

Looks amazing! Can we maintain the constant width on the code-block? Would this enable us to link to lines for #37?

Comment thread cbv/static/style.css Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these vendor prefixes are needed anymore for border radius: http://caniuse.com/border-radius

@mlen108

mlen108 commented Jun 6, 2013

Copy link
Copy Markdown

Bump

@meshy

meshy commented Jun 6, 2013

Copy link
Copy Markdown
Contributor Author

Hey @mattack108, I'm sorry to put this off 'til after the weekend, but I'm moving house and everything's a bit up in the air. I'll give this another look as soon as I get the time, and try to push it live as soon as I merge it.

@mlen108

mlen108 commented Jun 6, 2013

Copy link
Copy Markdown

That's okay @meshy - take your time! I'm not in rush with this. Hope you get your new house sorted quickly.

@meshy

meshy commented Jun 6, 2013

Copy link
Copy Markdown
Contributor Author

Thankyou :)

meshy added a commit that referenced this pull request Jun 13, 2013
@meshy
meshy merged commit 2f8b161 into master Jun 13, 2013
@meshy

meshy commented Jun 13, 2013

Copy link
Copy Markdown
Contributor Author

Thanks again @mattack108.

@meshy
meshy deleted the fix-line-numbers branch June 13, 2013 13:07
@mlen108

mlen108 commented Jun 13, 2013

Copy link
Copy Markdown

You're welcome @meshy
You may also upgrade to django-pygmy 0.1.4 as it now officially supports Django 1.3-5 and Python 2.6-3.3 :D

@meshy

meshy commented Jun 13, 2013

Copy link
Copy Markdown
Contributor Author

Cool! I'll probably do that at the refresh-oxford weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants