Repository navigation
fix(code-review): pipeline root, singleton inputs, cache keys, stats and line anchors - #321
Merged
Merged
Conversation
# Conflicts: # CHANGELOG.md
…ine-bugs # Conflicts: # CHANGELOG.md
mikeangstadt
added a commit
that referenced
this pull request
Nov 3, 2026
main's #321 already keys the signals cache on the agent input bundle and drops diff_tip from the key; this branch keeps that key shape and retains its additive pieces (input_hash in the manifest, the no-changed-files cache bypass). The override-clock pin is dropped in favour of main's _iso_days_ago fixtures.
mikeangstadt
added a commit
that referenced
this pull request
Nov 3, 2026
…674-coverage-critic-cache-key main's #321 already keys the coverage_critic cache on the diff summary (without diff_tip), passes the summary to the critic via extra_inputs, and seeds a prior entry in its changed-diff regression. This branch keeps that shape and retains diff_summary_hash in the manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pre-existing
code-reviewpipeline bugs found while running the ISS-12737 campaign (#315, #319, #320).code-review3.12.0 → 3.12.1.Fixes
/code-review:deepand/code-review:shallow.${CLAUDE_PLUGIN_ROOT}only in the text of the command or skill being invoked. It does not fill it in for files the agent later opens with Read, and the variable is empty in Bash (verified with a throwaway plugin).deep.mdandshallow.mdtell the agent to read and followstart.md, whose stage 0b echoed${CLAUDE_PLUGIN_ROOT}in Bash, got nothing, and fell back to the in-repo tree or the highest-version marketplace cache, possibly a different version from the one invoked.deep.mdandshallow.mdnow bindPLUGIN_ROOTexplicitly.start.mdtakes the root from that binding or its own substituted text, checks it as a literal path, and uses the fallbacks only when neither yields one.skills/fix/SKILL.mdreads its templates from${CLAUDE_PLUGIN_ROOT}instead of a never-filled<CLAUDE_PLUGIN_ROOT>placeholder. A sweep found no other file that reads the root after loading.taxonomy_path, and the coverage critic was never givendiff_summary_path. Both prompts named files they never received. Manifest paths were relative to the review's checkout, which is not the agent's working directory on worktree runs.extra_inputs(absolute paths). The singleton-dispatch template hands over exactly that list. Both prompts name the files they actually receive."HEAD".diff_tipis"HEAD"for branch reviews, so every later review of any branch could reuse the first run's signals and coverage-critic output.--diff-tipplumbing for stages 11 and 15 is removed.tentative_count,downgrade_count,skipped_countand the per-reviewertentativebucket now count real verdicts. The local and GitHub summaries were counting JUSTIFIED-INVALID and unverified findings as "CONFIRMED + DOWNGRADE"; that formula is corrected, and they gain a "Not verified (skipped)" line.records.py:267on a 22-line file, so the same bug appeared twice.validatenow re-anchors such a finding by itscode_snippet(recordingline_reanchored_from) before duplicates are merged. If there is no single match, it keeps the finding taggedline_out_of_rangeand shows it in the summary only; it is never posted inline and never discarded.Verification
uv run pytest plugins/code-review/tools/python/ -q: 1459 passed, 3 skipped.uv run ruff check .: pass.uv run pyright: 0 errors./code-review:deepruns loading this branch's plugin via--plugin-dir, on a test repo outside the monorepo, so the in-repo fallback could not supply the helpers.prompt_pathpoints into it.extra_inputs(absolute path) and returned signals. It previously returned none.downgrade_countwas 1, matching the verifier's one DOWNGRADE (previously hard-coded 0).needs_agentwith a different key from the first run, although the first run's entry was in the global cache. The old"HEAD"key would have reused it.Notes
code-reviewto 3.12.1. Whichever merges second needs re-bumping to 3.12.2 and its changelog heading regenerated.--depth deepreview spawns only thefastagent, so the always-on Design Critic is dropped.review_result.json.