Skip to content

ISS-14140: Read the real oversized routine list - #436

Merged
shafty023 merged 1 commit into
mainfrom
fix/iss-14140-too-large
Nov 16, 2026
Merged

shafty023 merged 1 commit into
mainfrom
fix/iss-14140-too-large

Conversation

@shafty023

Copy link
Copy Markdown
Collaborator

Summary

  • Problem. ISS-13998, ISS-14140: Remove vibe's cloud routines, fix check #432 (ISS-14140) still left cloud-worker.mjs check failing on merged main with CLOUD_RESULT_TOO_LARGE.
  • Real result, captured with Claude Code 2.1.323 by running the exact claude -p call remoteTrigger makes for list (read-only list and get, no routine changed):
    • The tool result is a <persisted-output> placeholder: "Output too large (166.5KB). Full output saved to: ~/.claude/projects///tool-results/toolu_*.txt", then a 2 KB preview.
    • The page holds 20 routines, all disabled, with has_more true and a next_cursor.
    • The saved file does not exist after the run, and neither does its session directory, because remoteTrigger passes --no-session-persistence. ISS-13998, ISS-14140: Remove vibe's cloud routines, fix check #432's file read therefore always failed.
    • The same stream-json user event carries tool_use_result: { status: 200, json } with the full 170,489-character body. For an inline get result, HTTP ${status}\n${json} equals the tool_result text exactly.
  • Fix (plugins/vibe-core/lib/vibe/scripts/cloud-worker.mjs): remoteTrigger keeps the tool_use_result of the event that holds our tool_result. When the text is a complete <persisted-output> placeholder and that result has an integer status and a string json, the reply is read from it. Inline results, the saved-file fallback, partial saves and <truncated-output> behave as before. plugins/vibe/skills/vibe/scripts/cloud-worker.mjs re-exports this file, so it is unchanged.
  • Versions. vibe 1.1.93 and vibe-core 1.0.12. Open work holds 1.1.87, 1.1.88, 1.1.89 and 1.1.91, and 1.1.92 is planned. CHANGELOG.md was regenerated with /update-documentation.

Breaking changes

None. This is an additive read path. Every other result shape keeps its behavior.

Test plan

  • New test in cloud-worker.test.mjs, built from the real capture with every value redacted: the event's real keys, the placeholder format, a saved path that does not exist, and 20 routines with the 24 real keys at the captured sizes. A second case drops tool_use_result and still gets CLOUD_RESULT_TOO_LARGE.
  • On 14d9016 the new test fails with CLOUD_RESULT_TOO_LARGE. Mutation proof: disabling the tool_use_result branch fails it again, and reverting the mutation makes it pass.
  • Node tests: cloud-worker 35/35, cloud-environment 10/10, cloud-repository 8/8, pr-create-guard 8/8, vibe-core 5/5, codex-session-worktree 26/26, fleet 32/32, writer-placement 6/6, vibe-triage 39/39, instruction-words 5/5, reply-checker 4/4.
  • pytest on the touched version-pin and CHANGELOG contract files: 44 passed. tools/plugin-manifests: 12/12.
  • Real FLEET_HOME=~/fleet-orchestrator node plugins/vibe/skills/vibe/scripts/cloud-worker.mjs check from this branch: "ok":true, with api ok "the routine API answers for this account (20 routines)".
  • Not run locally: the whole Python and node lanes. CI runs them.

remoteTrigger runs claude with --no-session-persistence, so the file a
persisted-output placeholder names is never written. Read the reply from
the stream event's tool_use_result instead; keep the saved-file read as
the fallback. vibe 1.1.93, vibe-core 1.0.12.
@shafty023
shafty023 merged commit c651459 into main Nov 16, 2026
11 of 12 checks passed
@shafty023
shafty023 deleted the fix/iss-14140-too-large branch November 16, 2026 17:06
shafty023 added a commit that referenced this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant