Repository navigation
ISS-14140: Read the real oversized routine list - #436
Merged
Merged
Conversation
remoteTrigger runs claude with --no-session-persistence, so the file a persisted-output placeholder names is never written. Read the reply from the stream event's tool_use_result instead; keep the saved-file read as the fallback. vibe 1.1.93, vibe-core 1.0.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud-worker.mjs checkfailing on merged main withCLOUD_RESULT_TOO_LARGE.claude -pcallremoteTriggermakes forlist(read-only list and get, no routine changed):<persisted-output>placeholder: "Output too large (166.5KB). Full output saved to: ~/.claude/projects///tool-results/toolu_*.txt", then a 2 KB preview.has_moretrue and anext_cursor.remoteTriggerpasses--no-session-persistence. ISS-13998, ISS-14140: Remove vibe's cloud routines, fix check #432's file read therefore always failed.userevent carriestool_use_result: { status: 200, json }with the full 170,489-character body. For an inlinegetresult,HTTP ${status}\n${json}equals the tool_result text exactly.plugins/vibe-core/lib/vibe/scripts/cloud-worker.mjs):remoteTriggerkeeps thetool_use_resultof the event that holds our tool_result. When the text is a complete<persisted-output>placeholder and that result has an integerstatusand a stringjson, the reply is read from it. Inline results, the saved-file fallback, partial saves and<truncated-output>behave as before.plugins/vibe/skills/vibe/scripts/cloud-worker.mjsre-exports this file, so it is unchanged.Breaking changes
None. This is an additive read path. Every other result shape keeps its behavior.
Test plan
cloud-worker.test.mjs, built from the real capture with every value redacted: the event's real keys, the placeholder format, a saved path that does not exist, and 20 routines with the 24 real keys at the captured sizes. A second case dropstool_use_resultand still getsCLOUD_RESULT_TOO_LARGE.CLOUD_RESULT_TOO_LARGE. Mutation proof: disabling thetool_use_resultbranch fails it again, and reverting the mutation makes it pass.FLEET_HOME=~/fleet-orchestrator node plugins/vibe/skills/vibe/scripts/cloud-worker.mjs checkfrom this branch:"ok":true, with api ok "the routine API answers for this account (20 routines)".