Skip to content

feat: model shared validation blockers in findings - #74

Open
Dante-dan wants to merge 1 commit into
cloudflare:mainfrom
Dante-dan:feat/shared-validation-blockers
Open

Dante-dan wants to merge 1 commit into
cloudflare:mainfrom
Dante-dan:feat/shared-validation-blockers

Conversation

@Dante-dan

Copy link
Copy Markdown

Summary

Model a shared deployment fact once in findings.json, with stable IDs referenced by needs_validation candidates. This implements #73 through a new record_kind: "shared_blocker" in the existing array; legacy findings arrays stay valid.

  • Shared records contain the exact fact, bounded owner-observed check, open/settled status, and settlement evidence when settled. Optional blocker_ids supplement the existing candidate blockers and validation plan.
  • The validator checks unknown/duplicate IDs, reference uniqueness, deterministic ordering, status/evidence consistency, and every stale reference to a settled fact. CLI counts keep shared records separate from findings.
  • Phase 6 instructions derive a shared-facts table from the final validated array, ranked by dependent candidate count, with linked lead references and separate settled provenance. Report generation here is specified by the skill instructions rather than a standalone renderer.

Settling one fact identifies every dependent candidate through validator errors. Each candidate must then be re-evaluated, remove its obsolete reference, and retain only real unresolved blockers or complete independent validation. The validator deliberately does not promote a candidate to confirmed merely because an owner observed a deployment fact.

Validation

node --test skills/security-audit/validate-findings.test.cjs skills/security-audit/validate-coverage-ledger.test.cjs: 72 passed, 0 failed. Includes compatibility, shared dependencies, missing/duplicate IDs, settled references, evidence, ordering, verdict separation, and CLI finding counts.

git diff --check: passed.

These are local validator/schema checks. No live deployment probe or target audit was performed.

Refs #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant