Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model a shared deployment fact once in
findings.json, with stable IDs referenced byneeds_validationcandidates. This implements #73 through a newrecord_kind: "shared_blocker"in the existing array; legacy findings arrays stay valid.blocker_idssupplement the existing candidate blockers and validation plan.Settling one fact identifies every dependent candidate through validator errors. Each candidate must then be re-evaluated, remove its obsolete reference, and retain only real unresolved blockers or complete independent validation. The validator deliberately does not promote a candidate to confirmed merely because an owner observed a deployment fact.
Validation
node --test skills/security-audit/validate-findings.test.cjs skills/security-audit/validate-coverage-ledger.test.cjs: 72 passed, 0 failed. Includes compatibility, shared dependencies, missing/duplicate IDs, settled references, evidence, ordering, verdict separation, and CLI finding counts.git diff --check: passed.These are local validator/schema checks. No live deployment probe or target audit was performed.
Refs #73