[NathanDrake2406]

Fixes #2409

Overview

The app-with-src dev overlay recovery E2E now waits for the shared App Router hydration signal before setting the reload canary and clicking the recovery Link.

Why

The flaky failure was a real test race: the previous wait only proved that the navigation runtime object existed. It did not prove React had hydrated the client tree that intercepts the Link click, so CI could occasionally perform a hard navigation before the soft-nav path was ready.

What changed

• Replaced the partial runtime-exists polling with waitForAppRouterHydration(page).
• Kept the actual browser click path so the test still covers the user-visible recovery flow.

Validation

• PLAYWRIGHT_PROJECT=app-with-src vp exec playwright test tests/e2e/app-with-src/dev-overlay-recovery.spec.ts --project=app-with-src --repeat-each=10 --retries=0
• PLAYWRIGHT_PROJECT=app-with-src vp exec playwright test --project=app-with-src --retries=0
• vp check tests/e2e/app-with-src/dev-overlay-recovery.spec.ts

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@2410

npm i https://pkg.pr.new/vinext@2410

commit: 2646508

[github-actions]

Performance benchmarks

Compared 2646508 against base 23ed801 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario	Framework	Baseline	Current	Change
Client bundle size (gzip)	vinext	124.0 KB	124.0 KB	⚫ +0.0%
Client entry size (gzip)	vinext	118.8 KB	118.8 KB	⚫ 0.0%
Dev server cold start	vinext	2.53 s	2.49 s	⚫ -1.5%
Production build time	vinext	3.07 s	3.07 s	⚫ -0.1%
RSC entry closure size (gzip)	vinext	95.2 KB	95.2 KB	⚫ +0.0%
Server bundle size (gzip)	vinext	161.5 KB	161.5 KB	⚫ -0.0%

View detailed results and traces

_{🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head}