Repository navigation
test: red check for #3430 params replay e2e (do not merge) - #3447
Closed
james-elicx wants to merge 1 commit into
Closed
james-elicx wants to merge 1 commit into
james-elicx wants to merge 1 commit into
Conversation
Adds only the use-cache-params fixture and e2e from #3430 on top of main, without the runtime fix, to show the test fails.
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Member
Author
|
Red confirmed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway draft to show the Response Store e2e added in #3430 fails without its runtime fix.
This branch is
mainplus only theuse-cache-paramsfixture and theregenerates a use-cache value keyed by promise params under its original keye2e from #3430. Expected:@vinext/cloudflare#testfails onassert.notEqual(fresh, first). Will be closed once CI reports.