Skip to content

fix(cli): preserve legacy config-time dotenv and ESM setup - #3495

Merged
james-elicx merged 2 commits into
codex/vite-command-adoptionfrom
codex/vinext-wrapper-legacy-compat
Sep 27, 2026
Merged

james-elicx merged 2 commits into
codex/vite-command-adoptionfrom
codex/vinext-wrapper-legacy-compat

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Stack created with GitHub Stacks CLI • Give Feedback 💬

@james-elicx
james-elicx added this pull request to stack #3382 September 26, 2026 22:01
@pkg-pr-new

pkg-pr-new Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3495

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3495

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3495

vinext

npm i https://pkg.pr.new/vinext@3495

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3495

commit: 65b75db

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
workers-cache preview production
kv preview production
static-export preview production
web preview production

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 65b75db against base f82f798 using alternating same-runner rounds. Next.js was unchanged and skipped.

1 improved · 1 regressed · 4 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.3 KB ⚫ 0.0%
Client entry size (gzip) vinext 130.4 KB 130.4 KB ⚫ -0.0%
Dev server cold start vinext 2.52 s 2.45 s 🟢 -2.6%
Production build time vinext 2.65 s 2.69 s 🔴 +1.6%
RSC entry closure size (gzip) vinext 128.2 KB 128.2 KB ⚫ -0.0%
Server bundle size (gzip) vinext 226.8 KB 226.8 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

Comment thread packages/vinext/src/cli.ts Resolved
@ask-bonk

ask-bonk Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

Comment thread packages/vinext/src/cli.ts Resolved
@ask-bonk

ask-bonk Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Posted 1 actionable inline finding.

github run

@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx
james-elicx force-pushed the codex/vinext-wrapper-legacy-compat branch from a4559e0 to cd280f2 Compare September 26, 2026 22:40
@james-elicx

Copy link
Copy Markdown
Member Author

/bigbonk review for issues

Time limit: 8 minutes. Complete the review and post all findings within that limit.

@ask-bonk

ask-bonk Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

LGTM!

github run

@james-elicx
james-elicx force-pushed the codex/vinext-wrapper-legacy-compat branch from cd280f2 to bb44a30 Compare September 26, 2026 22:48
@james-elicx
james-elicx force-pushed the codex/vinext-wrapper-legacy-compat branch from bb44a30 to 023e7ee Compare September 26, 2026 22:53
@james-elicx
james-elicx marked this pull request as ready for review September 26, 2026 23:03
@james-elicx
james-elicx force-pushed the codex/vinext-wrapper-legacy-compat branch from 023e7ee to 65b75db Compare September 27, 2026 00:01
@james-elicx
james-elicx merged commit 408a8ec into main Sep 27, 2026
80 checks passed
@james-elicx
james-elicx deleted the codex/vinext-wrapper-legacy-compat branch September 27, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant