Skip to content

fix(cloudflare): accept response store account and observability options - #3499

Merged
james-elicx merged 1 commit into
mainfrom
codex/response-store-config-options
Sep 26, 2026
Merged

james-elicx merged 1 commit into
mainfrom
codex/response-store-config-options

Conversation

@james-elicx

Copy link
Copy Markdown
Member

Summary

  • Accept the full observability configuration using the installed Cloudflare Vite plugin’s public WorkerConfig type.
  • Accept optional accountId outside worker and return it at the top level for defineConfig. It is never placed inside either Worker config.
  • Document both options and verify their placement in real Cloudflare Build Output.

No deployment behavior changes or changes to the Workers Response Store library.

Validation

  • 13 focused config tests passed, including optional-peer loading and omitted accountId.
  • 6 generated-project build tests passed, including service-binding preview and generated-project type-checking.
  • Verified accountId in root config.json and nested observability options in the Response Store worker.config.json.
  • Targeted formatting, lint, and type checks passed.
  • @vinext/cloudflare package build passed.

Based on latest main at b1eb146.

@pkg-pr-new

pkg-pr-new Bot commented Sep 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vinext/cloudflare

npm i https://pkg.pr.new/@vinext/cloudflare@3499

create-vinext-app

npm i https://pkg.pr.new/create-vinext-app@3499

@vinext/types

npm i https://pkg.pr.new/@vinext/types@3499

vinext

npm i https://pkg.pr.new/vinext@3499

@cloudflare/workers-response-store

npm i https://pkg.pr.new/@cloudflare/workers-response-store@3499

commit: 4dd5ec4

@james-elicx
james-elicx marked this pull request as ready for review September 26, 2026 23:50
@james-elicx
james-elicx enabled auto-merge (squash) September 26, 2026 23:50
@james-elicx
james-elicx merged commit 9f0af6f into main Sep 26, 2026
76 checks passed
@james-elicx
james-elicx deleted the codex/response-store-config-options branch September 26, 2026 23:51
@github-actions

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
response-store-demo preview production
workers-cache preview production
kv preview production
static-export preview production
web preview production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant