[hyoban]

Currently, this is pointing to the wrong value.

[southpolesteve]

/bigbonk review

[ask-bonk]

Clean fix. The load hook in Vite/Rolldown doesn't bind this to the plugin object — it binds to the Rolldown plugin context instead, so (this as any)._dimCache was always undefined. Hoisting the Map to a closure variable is the correct approach.

One minor note: now that _dimCache is no longer accessed via this, the property assignment on the plugin object (line 2577: _dimCache: imageImportDimCache) and the type assertion at line 2670 (as Plugin & { _dimCache: ... }) are dead code. Consider removing both to keep things tidy — the property only existed to support the old (this as any)._dimCache pattern.

[ask-bonk]

Nit: This property is now dead code — nothing reads _dimCache from the plugin object anymore. Consider removing it (and the corresponding & { _dimCache: ... } type assertion at line 2670) to keep the plugin definition clean.

[ask-bonk]

Review submitted. Here's a summary:

Approved — This is a correct fix. The load hook in Vite/Rolldown binds this to the Rolldown plugin context, not the plugin object itself, so (this as any)._dimCache was resolving to undefined and the cache was never working. Hoisting the Map to a closure variable (imageImportDimCache) is the right solution.

Left one minor nit: the _dimCache property on the plugin object and its type assertion are now dead code and could be cleaned up.

github run

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vinext@59

commit: 75c00ac

[FredKSchott]

LGTM, thanks @hyoban !