Repository navigation
Conversation
This is actually the expected behavior in several cases and should not be a cause for concern: - Non-exception outcomes other than OK may describe the ground truth more accurately than "exception", e.g. when exceededCpu is reported for an "exceeded CPU time limit" exception. - A background task failure may lead to a canceled outcome – we should report the exception so the developer can understand what caused the cancellation. - For some disconnects, we report OK outcomes to avoid noise but may still report exceptions caused by the disconnect like "Network connection lost" to indicate that the request actually disconnected. - We may get exceptions from waitUntil tasks that finish running after a fetch request has already returned its response successfully – in that case it is only right to report an OK outcome since the fetch succeeded while still reporting the exception so that the developer is aware of the task failure. - I was able to identify one case where this is genuinely an issue: This is being addressed in #7578.
Contributor
|
LGTM! Reviewed commit: 02970b7d · github run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is actually the expected behavior in several cases and should not be a cause for concern:
This warning helped us identify some real-world issues, but at the end of the day the assumption that exceptions should only be reported when there's an exception outcome don't really reflect how worker requests behave in practice.
#7578 should land before this PR. Internal PR !15327 is also related but may actually increase the volume of this warning since it affects one of the benign cases, so it's probably better to land this first.